public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: Fix sys_call_table type in asm/syscall.h
Date: Wed, 8 Jun 2011 10:25:00 +0200	[thread overview]
Message-ID: <20110608082500.GA20162@elte.hu> (raw)
In-Reply-To: <20110608081711.GG27166@one.firstfloor.org>


* Andi Kleen <andi@firstfloor.org> wrote:

> > There's an obvious problem with this patch, please fix it and resend.
> 
> Nothing obvious to me. Can you be more specific?

Sure, a trivial git grep of the sys_call_ptr_t typedef you added to 
syscall.h shows:

 ~/tip> git grep sys_call_ptr_t
 arch/um/sys-x86_64/syscall_table.c:typedef void (*sys_call_ptr_t)(void);
 arch/x86/include/asm/syscall.h:typedef void (*sys_call_ptr_t)(void);
 arch/x86/kernel/syscall_64.c:typedef void (*sys_call_ptr_t)(void);

So you've now added a third typedef in addition to the two existing 
ones. We obivously only want one in the kernel - the one you added to 
the header file.

Thanks,

	Ingo

      reply	other threads:[~2011-06-08  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07 23:45 [PATCH] x86: Fix sys_call_table type in asm/syscall.h Andi Kleen
2011-06-08  8:03 ` Ingo Molnar
2011-06-08  8:17   ` Andi Kleen
2011-06-08  8:25     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110608082500.GA20162@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox