From: Andi Kleen <andi@firstfloor.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/3] x86: Readd asmregparm
Date: Wed, 8 Jun 2011 18:01:28 +0200 [thread overview]
Message-ID: <20110608160128.GN27166@one.firstfloor.org> (raw)
In-Reply-To: <BANLkTimZ65o-gRf8n3SRzTedd=fTCB55QQ@mail.gmail.com>
> So from my point of view, none of the changelogs explain why the
> changes needed. Now, I'm not an expert on the x86 code so maybe I'm
> that you need it some unspecified follow-up patchkit. HTH.
Proper asmlinkages are imho a cleanliness feature that stands
on its own. They have been used in the past for all kinds of things,
but unfortunately have bitrotted recently on x86.
If nothing else they are useful documentation. For example
if you do grep for *.[ch] only and you hit an asmlinkage it's a good
hint to look into the .S too. In general you need to be much more
careful about any changes to those, because assembler is more fragile.
I have been encouraged by other people to post those early, so I did.
and at least in my traditional Linux development world view posting
patches early is the right thing to do.
-Andi
prev parent reply other threads:[~2011-06-08 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 1:09 [PATCH 1/3] x86: Readd asmregparm Andi Kleen
2011-06-08 1:10 ` [PATCH 2/3] x86: Add missing asmlinkages/asmregparm Andi Kleen
2011-06-08 1:10 ` [PATCH 3/3] x86: Change dotraplinkage into asmregparm for 32bit Andi Kleen
2011-06-08 8:19 ` [PATCH 1/3] x86: Readd asmregparm Ingo Molnar
2011-06-08 8:37 ` Andi Kleen
2011-06-08 8:53 ` Ingo Molnar
2011-06-08 11:57 ` Pekka Enberg
2011-06-08 12:28 ` Christoph Lameter
2011-06-08 16:01 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110608160128.GN27166@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox