From: Ingo Molnar <mingo@elte.hu>
To: Dave Airlie <airlied@gmail.com>
Cc: jbarnes@virtuousgeek.org, linux-kernel@vger.kernel.org,
Dave Airlie <airlied@redhat.com>,
steiner@sgi.com
Subject: Re: [PATCH] uv/x2apic: update for change in pci bridge handling.
Date: Thu, 9 Jun 2011 09:09:12 +0200 [thread overview]
Message-ID: <20110609070912.GB20544@elte.hu> (raw)
In-Reply-To: <BANLkTi=8JQWojj4UrH1iBYN=tWdx5AuOCA@mail.gmail.com>
* Dave Airlie <airlied@gmail.com> wrote:
> On Wed, May 25, 2011 at 2:00 PM, Dave Airlie <airlied@gmail.com> wrote:
> > From: Dave Airlie <airlied@redhat.com>
> >
> > I forgot about the special uv handling code for this, so this
> > patch fixes it up.
>
> ping?
>
> This fixes a warning and bug in Linus tree,
>
> CC arch/x86/kernel/apic/x2apic_uv_x.o
> /home/airlied/git/linux-2.6/arch/x86/kernel/apic/x2apic_uv_x.c: In
> function ‘uv_system_init’:
> /home/airlied/git/linux-2.6/arch/x86/kernel/apic/x2apic_uv_x.c:882:2:
> warning: passing argument 1 of ‘pci_register_set_vga_state’ from
> incompatible pointer type [enabled by default]
> /home/airlied/git/linux-2.6/include/linux/pci.h:1094:13: note:
> expected ‘arch_set_vga_state_t’ but argument is of type ‘int
> (*)(struct pci_dev *, bool, unsigned int, bool)’
>
>
> Dave.
>
> >
> > Signed-off-by: Dave Airlie <airlied@redhat.com>
> > ---
> > arch/x86/kernel/apic/x2apic_uv_x.c | 8 ++++----
> > drivers/pci/pci.c | 4 ++--
> > 2 files changed, 6 insertions(+), 6 deletions(-)
Bug introduced via the DRM tree? Then the fix should go via the DRM
tree or via the PCI tree i suspect.
Thanks,
Ingo
next prev parent reply other threads:[~2011-06-09 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 4:00 [PATCH] uv/x2apic: update for change in pci bridge handling Dave Airlie
2011-06-09 3:43 ` Dave Airlie
2011-06-09 7:09 ` Ingo Molnar [this message]
2011-06-09 10:32 ` Dave Airlie
2011-06-09 11:16 ` Ingo Molnar
2011-06-09 15:13 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609070912.GB20544@elte.hu \
--to=mingo@elte.hu \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).