From: Ingo Molnar <mingo@elte.hu>
To: Robert Richter <robert.richter@amd.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
oprofile-list <oprofile-list@lists.sourceforge.net>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
stable@kernel.org
Subject: Re: [PATCH] oprofile, x86: Fix race in nmi handler while starting
Date: Thu, 9 Jun 2011 09:18:54 +0200 [thread overview]
Message-ID: <20110609071854.GE20544@elte.hu> (raw)
In-Reply-To: <1307465249-20055-1-git-send-email-robert.richter@amd.com>
* Robert Richter <robert.richter@amd.com> wrote:
> In some rare cases, nmis are generated immediately after the nmi
> handler of the cpu was started. This causes the counter not to be
> enabled. Before enabling the nmi handlers we need to set variable
> ctr_running first and make sure its value is written to memory.
>
> Also, the patch makes all existing barriers a memory barrier
> instead of a compiler barrier only.
Could we *PLEASE* just do the obvious and turn oprofile into a perf
user on x86 too, like ARM already does? Two years down the line and
there's zero progress in that area. We want to obsolete the Oprofile
PMU bits on x86, the infrastructure duplication causes non-trivial
problems like this one.
Thanks,
Ingo
next prev parent reply other threads:[~2011-06-09 7:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 16:47 [PATCH] oprofile, x86: Fix race in nmi handler while starting Robert Richter
2011-06-09 7:18 ` Ingo Molnar [this message]
2011-06-16 15:25 ` Robert Richter
2011-06-17 8:06 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609071854.GE20544@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sourceforge.net \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=stable@kernel.org \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox