Re: [PATCH] x86: CONFIG_EFI should select CONFIG_RELOCATABLE

H. Peter Anvin
2011-06-09T14:37:35Z

On 06/09/2011 07:32 AM, Matthew Garrett wrote:
> EFI doesn't provide any guarantees that any given address will be free,
> so the bootloader must have the freedom to position the kernel
> appropriately. Make CONFIG_EFI select CONFIG_RELOCATABLE in order to
> ensure that this constraint is satisfiable.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
> ---
> arch/x86/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index da34972..580cd31 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1454,6 +1454,7 @@ config ARCH_USES_PG_UNCACHED
> config EFI
> bool "EFI runtime service support"
> depends on ACPI
> + select RELOCATABLE
> ---help---
> This enables the kernel to use EFI runtime services that are
> available (such as the EFI variable services).

Can we make this a depends on instead of select?

-hpa