From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Joe Perches <joe@perches.com>
Cc: Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] regulator: Add rdev_crit() macro
Date: Thu, 9 Jun 2011 20:09:26 +0100 [thread overview]
Message-ID: <20110609190925.GD2821@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1307644635.13329.36.camel@Joe-Laptop>
On Thu, Jun 09, 2011 at 11:37:15AM -0700, Joe Perches wrote:
> > +#define rdev_crit(rdev, fmt, ...) \
> > + pr_crit("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
> If that's really necessary, shouldn't rdev_emerg, rdev_alert
> and rdev_notice be added as well?
Yes, but I don't habitually use those when adding random trace during
debug so don't care myself.
prev parent reply other threads:[~2011-06-09 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 15:06 [PATCH] regulator: Add rdev_crit() macro Mark Brown
2011-06-09 18:15 ` Liam Girdwood
2011-06-09 18:37 ` Joe Perches
2011-06-09 19:09 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609190925.GD2821@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox