From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: jj@chaosbits.net, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] Sparc: Remove trigraph in die_if_kernel() message.
Date: Fri, 10 Jun 2011 00:03:22 +0100 [thread overview]
Message-ID: <20110609230322.GY11521@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20110609.155943.162785602513776337.davem@davemloft.net>
On Thu, Jun 09, 2011 at 03:59:43PM -0700, David Miller wrote:
> > If I'm not mistaken, that "??!" will be taken as a trigraph for "|" by the
> > preprocessor, so the final string will end up either as
> > "Penguin instruction from Penguin mode|?!"
Not without -trigraphs, which is not on by default...
> Applied, thanks Jesper :-)
BTW, idiomatic way to deal with those is to use \? instead of string concat...
next prev parent reply other threads:[~2011-06-09 23:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 14:38 [PATCH][RFC] Sparc: Remove trigraph in die_if_kernel() message Jesper Juhl
2011-06-09 22:59 ` David Miller
2011-06-09 23:03 ` Al Viro [this message]
2011-06-09 23:06 ` David Miller
2011-06-10 7:51 ` Jesper Juhl
2011-06-12 7:23 ` Daniel K.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609230322.GY11521@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox