From: Christoph Hellwig <hch@infradead.org>
To: Clement LECIGNE <clement.lecigne@netasq.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BUG] hfs_find_init() sb->ext_tree NULL pointer dereference
Date: Fri, 10 Jun 2011 17:40:36 -0400 [thread overview]
Message-ID: <20110610214036.GA23163@infradead.org> (raw)
In-Reply-To: <20110608110731.GA69446@clem1.netasq.com>
On Wed, Jun 08, 2011 at 01:07:55PM +0200, Clement LECIGNE wrote:
> Hi,
>
> hfs_find_init() is wrongly assuming that sb->ext_tree has already been opened
> and is not NULL but this function can be called when sb->ext_tree is currently
> being opened (NULL deref).
Well, it can't happen in practice. The extent file always fits into
the first blocks for a valid extents file. And yes, you could
artifically construct a filesystem where this is not true, and if you
want to be cool call it a security issue. But in the end anyone who
mounts untrusted disk images has much worse issues than this, so don't
do it.
next prev parent reply other threads:[~2011-06-10 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 11:07 [BUG] hfs_find_init() sb->ext_tree NULL pointer dereference Clement LECIGNE
2011-06-10 21:40 ` Christoph Hellwig [this message]
2011-06-11 10:30 ` Clement LECIGNE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110610214036.GA23163@infradead.org \
--to=hch@infradead.org \
--cc=clement.lecigne@netasq.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox