From: Jean Sacren <sakiwit@gmail.com>
To: Andy Isaacson <adi@hexapodia.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] kernel/sched.c: Fix array initialization typo
Date: Sun, 12 Jun 2011 18:51:22 -0600 [thread overview]
Message-ID: <20110613005122.GC12311@mail.gmail.com> (raw)
In-Reply-To: <20110612230901.GB11580@hexapodia.org>
From: Andy Isaacson <adi@hexapodia.org>
Date: Sun, 12 Jun 2011 16:09:01 -0700
>
> It is a standard C idiom for defining array contents. If you write
> int x[] = {
> 1,
> 2,
> 3
> };
>
> then when I add a fourth element to your array, I have to modify two
> lines, and the diff will say
> - 3
> + 3,
> + 4
> };
>
> whereas if you wrote "3," as the last line of the initializer, the diff
> would be one line long.
I don't know how to thank you for this. Apparently the patch is bogus.
>
> Furthermore, spot the error in this diff:
>
> @@ -3,4 +3,5 @@ char *x[] = {
> "quick",
> "brown",
> "fox"
> + "jumped"
> };
>
> HTH, HAND,
> -andy
--
Jean Sacren
next prev parent reply other threads:[~2011-06-13 0:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 21:31 [PATCH 1/1] kernel/sched.c: Fix array initialization typo Jean Sacren
2011-06-12 21:35 ` Alexey Dobriyan
2011-06-12 22:01 ` Jean Sacren
2011-06-12 23:09 ` Andy Isaacson
2011-06-12 23:59 ` Randy Dunlap
2011-06-13 0:51 ` Jean Sacren [this message]
2011-06-14 18:49 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110613005122.GC12311@mail.gmail.com \
--to=sakiwit@gmail.com \
--cc=adi@hexapodia.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox