public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: linux-kernel@vger.kernel.org,
	kernel-hardening@lists.openwall.com,
	Andrew Morton <akpm@linux-foundation.org>,
	"Greg Kroah-Hartman" <gregkh@suse.de>,
	"David S. Miller" <davem@davemloft.net>,
	David Rientjes <rientjes@google.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Nick Piggin <npiggin@kernel.dk>,
	Miklos Szeredi <mszeredi@suse.cz>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	WANG Cong <xiyou.wangcong@gmail.com>
Subject: Re: [RFC v2 02/04] procfs: add hidepid modes as mount options
Date: Tue, 14 Jun 2011 15:54:50 +0200	[thread overview]
Message-ID: <201106141554.50945.arnd@arndb.de> (raw)
In-Reply-To: <1307889901-6226-1-git-send-email-segoon@openwall.com>

On Sunday 12 June 2011, Vasiliy Kulikov wrote:
> +static const match_table_t tokens = {
> +       {Opt_hidepid, "hidepid=%u"},
> +       {Opt_gid, "gid=%u"},
> +       {Opt_hidenet, "hidenet"},
> +       {Opt_nohidenet, "nohidenet"},
> +       {Opt_err, NULL},
> +};

I don't really have an opinion on your patch, but it seems that it does more than
the description explains: The hidenet/nohidenet option is in the patch as well,
although it doesn't have much of an effect.

	Arnd

  reply	other threads:[~2011-06-14 13:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-12 14:45 [RFC v2 02/04] procfs: add hidepid modes as mount options Vasiliy Kulikov
2011-06-14 13:54 ` Arnd Bergmann [this message]
2011-06-14 14:24   ` Vasiliy Kulikov
2011-06-14 14:48     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106141554.50945.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=gregkh@suse.de \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mszeredi@suse.cz \
    --cc=npiggin@kernel.dk \
    --cc=rientjes@google.com \
    --cc=segoon@openwall.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox