From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Huang Ying <ying.huang@intel.com>
Cc: Len Brown <lenb@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
"Luck, Tony" <tony.luck@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPI, APEI, Add APEI _OSC support
Date: Wed, 15 Jun 2011 13:17:03 +0100 [thread overview]
Message-ID: <20110615121703.GA8638@srcf.ucam.org> (raw)
In-Reply-To: <4DF82CBC.5070400@intel.com>
On Wed, Jun 15, 2011 at 11:53:32AM +0800, Huang Ying wrote:
> Hi, Matthew,
> On 06/14/2011 10:52 PM, Matthew Garrett wrote:
> > And then tear down GHES. This seems wrong. A platform could predicate
> > APEI functionality on the ACPI spec APEI indication (which we currently
> > don't pass) without implementing WHEA, but with this patch we'd refuse
> > to enable GHES support? We should probably try both the standard method
> > and the WHEA method and only disable GHES if both fail.
>
> You means the "APEI Support" bit for standard UUID? Do you know which
> machine uses this bit? I can write the code, but I have no machine to
> test it.
I have access to a Dell system that uses this.
> BTW, it is better for us to enable APEI firmware first mode (that is,
> what is enabled by evaluating the WHEA UUID) after GHES reporting is
> ready (that is, after GHES module is successfully loaded). That is
> later than current ACPI _OSC evaluation with standard UUID. Is it
> possible to evaluate _OSC with standard UUID twice? So that we can
> enable APEI firmware first mode later.
Urgh. One machine I've looked at enables APEI if the WHEA _OSC call is
made, and then clears a flag if any other _OSC call is made. In that
specific case it doesn't seem to matter (the flag never actually gets
checked in any of the other codepaths), but it seems that the intention
is for the generic call to be made and the WHEA one to be made after
that.
> > (Also, are there any other sideeffects of indicating that we support
> > WHEA?)
>
> After evaluating _OSC with this UUID, firmware will produce error record
> to OS, otherwise only unknown NMI.
Ok, that sounds fine.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-06-15 12:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 6:05 [PATCH] ACPI, APEI, Add APEI _OSC support Huang Ying
2011-06-13 14:50 ` Don Zickus
2011-06-14 6:33 ` Chen Gong
2011-06-14 12:11 ` Don Zickus
2011-06-14 14:52 ` Matthew Garrett
2011-06-15 3:53 ` Huang Ying
2011-06-15 12:17 ` Matthew Garrett [this message]
2011-06-16 0:40 ` Huang Ying
2011-06-16 1:38 ` Matthew Garrett
2011-06-16 1:55 ` Huang Ying
2011-06-16 1:57 ` Matthew Garrett
2011-06-17 0:57 ` Huang Ying
2011-06-17 1:34 ` Matthew Garrett
2011-06-17 1:40 ` Huang Ying
2011-06-17 1:42 ` Matthew Garrett
2011-06-17 1:53 ` Huang Ying
2011-06-16 9:00 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110615121703.GA8638@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=andi@firstfloor.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).