From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org, grant@secretlab.ca
Subject: Re: [PATCH] FRV: Hook up gpiolib support
Date: Wed, 15 Jun 2011 15:48:24 +0100 [thread overview]
Message-ID: <20110615144823.GA2806@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <5194.1308074912@redhat.com>
On Tue, Jun 14, 2011 at 07:08:32PM +0100, David Howells wrote:
> There's an ordering problem. The #inclusion of asm-generic/gpio.h must come
> both before *and* after the functions in asm/gpio.h. Take gpio_get_value()
> for instance, it requires __gpio_get_value() - which is defined by the generic
> header - but is used by gpio_get_value_cansleep() in the generic header.
Could you be more specific about the issue you see here? The arch
header includes the generic header which appears to prototype all the
functions before it uses them. I do also note that this is a verbatim
copy of the header that's been used on PowerPC for some considerable
time; is this some FRV specific limitation that wouldn't affect other
architectures?
> You must split asm-generic/gpio.h.
I must?
next prev parent reply other threads:[~2011-06-15 14:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 9:49 [PATCH] FRV: Hook up gpiolib support Mark Brown
2011-06-01 20:19 ` Grant Likely
2011-06-14 18:08 ` David Howells
2011-06-15 14:48 ` Mark Brown [this message]
2011-06-16 6:36 ` David Howells
2011-06-16 10:22 ` Mark Brown
2011-06-17 10:50 ` David Howells
2011-06-17 10:54 ` Felipe Balbi
2011-06-17 12:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110615144823.GA2806@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dhowells@redhat.com \
--cc=grant@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).