* [PATCH] regulator: max8952 - fix wrong gpio valid check
@ 2011-06-15 8:54 MyungJoo Ham
2011-06-15 15:42 ` Mark Brown
2011-07-04 16:05 ` Liam Girdwood
0 siblings, 2 replies; 3+ messages in thread
From: MyungJoo Ham @ 2011-06-15 8:54 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown, jhbird.choi, myungjoo.ham
From: Jonghwan Choi <jhbird.choi@samsung.com>
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
---
drivers/regulator/max8952.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c
index daff7fd..486ed81 100644
--- a/drivers/regulator/max8952.c
+++ b/drivers/regulator/max8952.c
@@ -139,7 +139,7 @@ static int max8952_set_voltage(struct regulator_dev *rdev,
s8 vid = -1, i;
if (!gpio_is_valid(max8952->pdata->gpio_vid0) ||
- !gpio_is_valid(max8952->pdata->gpio_vid0)) {
+ !gpio_is_valid(max8952->pdata->gpio_vid1)) {
/* DVS not supported */
return -EPERM;
}
--
1.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: max8952 - fix wrong gpio valid check
2011-06-15 8:54 [PATCH] regulator: max8952 - fix wrong gpio valid check MyungJoo Ham
@ 2011-06-15 15:42 ` Mark Brown
2011-07-04 16:05 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-06-15 15:42 UTC (permalink / raw)
To: MyungJoo Ham; +Cc: linux-kernel, Liam Girdwood, jhbird.choi, myungjoo.ham
On Wed, Jun 15, 2011 at 05:54:12PM +0900, MyungJoo Ham wrote:
> From: Jonghwan Choi <jhbird.choi@samsung.com>
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
This should actually be a signoff from you since you're part of the
chain of people forwarding on the patch.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: max8952 - fix wrong gpio valid check
2011-06-15 8:54 [PATCH] regulator: max8952 - fix wrong gpio valid check MyungJoo Ham
2011-06-15 15:42 ` Mark Brown
@ 2011-07-04 16:05 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-07-04 16:05 UTC (permalink / raw)
To: MyungJoo Ham
Cc: linux-kernel, Liam Girdwood, Mark Brown, jhbird.choi,
myungjoo.ham
On Wed, 2011-06-15 at 17:54 +0900, MyungJoo Ham wrote:
> From: Jonghwan Choi <jhbird.choi@samsung.com>
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> ---
> drivers/regulator/max8952.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c
> index daff7fd..486ed81 100644
> --- a/drivers/regulator/max8952.c
> +++ b/drivers/regulator/max8952.c
> @@ -139,7 +139,7 @@ static int max8952_set_voltage(struct regulator_dev *rdev,
> s8 vid = -1, i;
>
> if (!gpio_is_valid(max8952->pdata->gpio_vid0) ||
> - !gpio_is_valid(max8952->pdata->gpio_vid0)) {
> + !gpio_is_valid(max8952->pdata->gpio_vid1)) {
> /* DVS not supported */
> return -EPERM;
> }
Applied.
Thanks
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-04 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-15 8:54 [PATCH] regulator: max8952 - fix wrong gpio valid check MyungJoo Ham
2011-06-15 15:42 ` Mark Brown
2011-07-04 16:05 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox