From: Greg Dietsche <Gregory.Dietsche@cuw.edu>
To: Julia Lawall <julia@diku.dk>
Cc: linux-kernel@vger.kernel.org, cocci@diku.dk, Gilles.Muller@lip6.fr
Subject: Re: [Cocci] Re: [PATCH v2] coccinelle: if (ret) return ret; return ret; semantic patch
Date: Wed, 15 Jun 2011 11:05:24 -0500 [thread overview]
Message-ID: <20110615160524.GA9986@farmergreg.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1106151735020.10106@ask.diku.dk>
On Wed, Jun 15, 2011 at 05:35:47PM +0200, Julia Lawall wrote:
> > except that 4 of the 5 ORs are cases where we want to do the -return ret; +
> > return ret; So I suppose for performance, I should actually add the +/- to
> > each of the 4 cases that we want cocci to generate a patch for?
>
> Actually, it's probably not that big a deal. It's only rewriting the ones
> where there is a return ret just before, not all the returns in the code,
> like I was originally thinking.
Ok :) I'll update the patch one last time - hopefully we've got everything nailed
down now :)
thanks for being so incredibly helpful!
Greg
>
> julia
>
next prev parent reply other threads:[~2011-06-15 16:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 0:26 [PATCH] coccinelle: if(ret)return ret; return ret; semantic patch Greg Dietsche
2011-06-06 4:55 ` Julia Lawall
2011-06-07 15:47 ` Greg Dietsche
2011-06-07 16:56 ` Julia Lawall
2011-06-07 21:54 ` Nicolas Palix
2011-06-07 22:59 ` Greg Dietsche
2011-06-08 7:11 ` Nicolas Palix
2011-06-08 7:24 ` Julia Lawall
2011-06-11 15:37 ` Greg Dietsche
2011-06-11 15:43 ` Julia Lawall
2011-06-06 4:56 ` Julia Lawall
2011-06-13 18:23 ` [PATCH v2] coccinelle: if (ret) return " Greg Dietsche
2011-06-13 18:36 ` Joe Perches
2011-06-13 18:38 ` Julia Lawall
2011-06-13 20:55 ` Greg Dietsche
2011-06-14 5:50 ` Julia Lawall
2011-06-14 21:24 ` Greg Dietsche
2011-06-15 1:15 ` Greg Dietsche
2011-06-15 5:58 ` Julia Lawall
2011-06-15 15:33 ` [Cocci] " Greg Dietsche
2011-06-15 15:34 ` Julia Lawall
2011-06-15 15:35 ` Julia Lawall
2011-06-15 16:05 ` Greg Dietsche [this message]
2011-06-15 1:29 ` [PATCH v3] " Greg Dietsche
2011-06-15 5:50 ` Julia Lawall
2011-06-15 15:50 ` [PATCH v4] " Greg Dietsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110615160524.GA9986@farmergreg.com \
--to=gregory.dietsche@cuw.edu \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@diku.dk \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox