public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
	laijs@cn.fujitsu.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, josh@joshtriplett.org, niv@us.ibm.com,
	tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org,
	Valdis.Kletnieks@vt.edu, dhowells@redhat.com,
	eric.dumazet@gmail.com, darren@dvhart.com, patches@linaro.org
Subject: Re: [PATCH rcu/urgent] Banishing kthreads
Date: Fri, 17 Jun 2011 14:00:39 -0700	[thread overview]
Message-ID: <20110617210039.GK2258@linux.vnet.ibm.com> (raw)
In-Reply-To: <BLU0-SMTP59C2BC46DCAC5743FE5229966D0@phx.gbl>

On Fri, Jun 17, 2011 at 04:35:23PM -0400, Mathieu Desnoyers wrote:
> * Paul E. McKenney (paulmck@linux.vnet.ibm.com) wrote:
> > This patchset banishes RCU kthreads from non-RCU_BOOST kernel threads.
> > The two patches are as follows:
> > 
> > 1.	Minimal patch that #ifdefs out the kthread code.
> > 
> > 2.	Code-movement patch that puts the code #ifdefed out above
> > 	under existing #ifdefs in kernel/rcutree_plugin.h.
> 
> Hi Paul,
> 
> I'm wondering about the impact of this change: so I guess that before
> the change, it was OK to go on a waitqueue (might_sleep()) within a
> call_rcu callback, but since the execution now moves to a softirq
> handler in non-RCU_BOOST kernels, it's not allowed anymore. I might be
> missing something though: was sleeping within call_rcu handlers already
> prohibited ? (never had to sleep in those, so I never had to check if it
> was allowed)

The callbacks are still executed in BH context, so any attempt to
sleep should get a warning message.  Also, it switched to kthread quite
recently, so there hasn't been time for anyone to get used to it.  ;-)

							Thanx, Paul

      parent reply	other threads:[~2011-06-17 21:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-17  0:00 [PATCH rcu/urgent] Banishing kthreads Paul E. McKenney
2011-06-17  0:00 ` [PATCH tip/core/urgent 1/2] rcu: use softirq instead of kthreads except when RCU_BOOST=y Paul E. McKenney
2011-06-17  0:00 ` [PATCH tip/core/urgent 2/2] rcu: Move RCU_BOOST #ifdefs to header file Paul E. McKenney
2011-06-17 20:35 ` [PATCH rcu/urgent] Banishing kthreads Mathieu Desnoyers
     [not found] ` <BLU0-SMTP59C2BC46DCAC5743FE5229966D0@phx.gbl>
2011-06-17 21:00   ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110617210039.GK2258@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=darren@dvhart.com \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=eric.dumazet@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=niv@us.ibm.com \
    --cc=patches@linaro.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox