From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ravikiran Thirumalai <kiran@scalex86.org>,
William Irwin <wli@holomorphy.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>
Subject: [Patch] hugetlb: remove user_shm_lock() check from hugetlb_file_setup()
Date: Sat, 18 Jun 2011 15:13:08 +0800 [thread overview]
Message-ID: <20110618071308.GA24743@cr0> (raw)
This is a revert of
commit 2584e517320bd48dc8d20e38a2621a2dbe58fade
Author: Ravikiran G Thirumalai <kiran@scalex86.org>
Date: Tue Mar 31 15:21:26 2009 -0700
mm: reintroduce and deprecate rlimit based access for SHM_HUGETLB
because it is deprecated and scheduled to be removed.
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Ravikiran Thirumalai <kiran@scalex86.org>
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
---
diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index 72e2384..d627fd3 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -298,18 +298,6 @@ Who: Michael Buesch <mb@bu3sch.de>
---------------------------
-What: Ability for non root users to shm_get hugetlb pages based on mlock
- resource limits
-When: 2.6.31
-Why: Non root users need to be part of /proc/sys/vm/hugetlb_shm_group or
- have CAP_IPC_LOCK to be able to allocate shm segments backed by
- huge pages. The mlock based rlimit check to allow shm hugetlb is
- inconsistent with mmap based allocations. Hence it is being
- deprecated.
-Who: Ravikiran Thirumalai <kiran@scalex86.org>
-
----------------------------
-
What: CONFIG_THERMAL_HWMON
When: January 2009
Why: This option was introduced just to allow older lm-sensors userspace
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 7aafeb8..e2627a3 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -936,15 +936,8 @@ struct file *hugetlb_file_setup(const char *name, size_t size,
if (!hugetlbfs_vfsmount)
return ERR_PTR(-ENOENT);
- if (creat_flags == HUGETLB_SHMFS_INODE && !can_do_hugetlb_shm()) {
- *user = current_user();
- if (user_shm_lock(size, *user)) {
- printk_once(KERN_WARNING "Using mlock ulimits for SHM_HUGETLB is deprecated\n");
- } else {
- *user = NULL;
- return ERR_PTR(-EPERM);
- }
- }
+ if (creat_flags == HUGETLB_SHMFS_INODE && !can_do_hugetlb_shm())
+ return ERR_PTR(-EPERM);
root = hugetlbfs_vfsmount->mnt_root;
quick_string.name = name;
@@ -952,7 +945,7 @@ struct file *hugetlb_file_setup(const char *name, size_t size,
quick_string.hash = 0;
path.dentry = d_alloc(root, &quick_string);
if (!path.dentry)
- goto out_shm_unlock;
+ goto out;
path.mnt = mntget(hugetlbfs_vfsmount);
error = -ENOSPC;
@@ -983,11 +976,7 @@ out_inode:
iput(inode);
out_dentry:
path_put(&path);
-out_shm_unlock:
- if (*user) {
- user_shm_unlock(size, *user);
- *user = NULL;
- }
+out:
return ERR_PTR(error);
}
next reply other threads:[~2011-06-18 7:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-18 7:13 Américo Wang [this message]
2011-06-18 23:34 ` [Patch] hugetlb: remove user_shm_lock() check from hugetlb_file_setup() David Rientjes
2011-06-23 5:22 ` Américo Wang
2011-06-23 5:32 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110618071308.GA24743@cr0 \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox