Re: OpenRISC Architecture: Request for review

[Arnd Bergmann <arnd@arndb.de>]

On Sunday 19 June 2011 13:43:26 Jonas Bonn wrote:
> 
> This is a port of Linux to the OpenRISC 1000 architecture.
> 
> The OpenRISC architecture was conceived with the idea of creating a CPU
> with an open specification and freely licensed implementations thereof.
> The OR1200 implementation of the OpenRISC 1000 architecture is LGPL licensed,
> runs on FPGA's from a broad number of vendors, and is currently being
> used in a number of successful industrial projects.

Hi Jonas,

Thanks for your submission, it looks very nice and is well split up into
readable patches. I have no doubt that you will be able to get this included
in Linux-3.1 given the high quality. I'll go through the individual patches
and comment on anything that sticks out. Please resubmit once you have
addressed all of the comments from me and other people, and take
linux-arch@vger.kernel.org on Cc for the second round, because otherwise
some people may miss the patches in the daily flood.

> There's a short TODO.openrisc file, as well.  Some of the items listed
> there could potentially be done before any pull request for the architecture
> is sent.

How about including the TODO file here?

> There are also fair number of places where we still have old test code
> laying about inside #ifdefs and comments.  The intention is to get all that
> cleaned up before the final pull request, but I didn't want to allow that
> to delay beginning the review process any further.

I agree that this is important to clean it all up, but it's good that you
posted the current version.

I would also suggest that you let Stephen Rothwell add your git tree to
the linux-next sources, provided that it merges cleanly with the upstream
kernel.

	Arnd