public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Ian Lartey <ian@opensource.wolfsonmicro.com>,
	Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd/ab8500: Use kstrtoul_from_user
Date: Mon, 20 Jun 2011 21:46:15 +0200	[thread overview]
Message-ID: <201106202146.16585.PeterHuewe@gmx.de> (raw)
In-Reply-To: <BANLkTikKRVP4PW48YtR+mMMNsaxTDxoGtw@mail.gmail.com>

Am Montag 20 Juni 2011, 15:45:46 schrieb Alexey Dobriyan:
> NAK
> You should use kstrtou8_from_user() and drop 0xff check as well.
> 
> Do NOT blindly replace strict_strtoul with kstrtoul.

Thanks for spotting this - I'll review my other patches as well and redo them.
Sorry for any inconvenience.

Thanks,
Peter


  reply	other threads:[~2011-06-20 19:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06 20:43 [PATCH 1/2] mfd/ab3550: Use kstrtoul_from_user Peter Huewe
2011-06-06 20:43 ` [PATCH 2/2] mfd/ab8500: " Peter Huewe
2011-06-20 13:45   ` Alexey Dobriyan
2011-06-20 19:46     ` Peter Hüwe [this message]
2011-06-20 19:46     ` [PATCH 1/2 v2] mfd/ab3550: Convert to kstrtou8_from_user Peter Huewe
2011-06-20 19:50       ` Alexey Dobriyan
2011-06-20 20:16         ` Peter Hüwe
2011-06-20 21:01         ` [PATCH 1/2 v3] " Peter Huewe
2011-06-20 21:01         ` [PATCH 2/2 v4] mfd/ab8500: " Peter Huewe
2011-06-20 19:46     ` [PATCH 2/2 v2] " Peter Huewe
2011-06-20 19:51       ` [PATCH v3] " Peter Huewe
2011-06-20 13:29 ` [PATCH 1/2] mfd/ab3550: Use kstrtoul_from_user Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106202146.16585.PeterHuewe@gmx.de \
    --to=peterhuewe@gmx.de \
    --cc=adobriyan@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=ian@opensource.wolfsonmicro.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=srinidhi.kasagar@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox