Re: [PATCH 1/8] regmap: Add generic non-memory mapped register access API

Dimitris Papastamos
2011-06-21T11:47:14Z

On Tue, Jun 21, 2011 at 02:24:30AM +0100, Mark Brown wrote:
> On Tue, Jun 21, 2011 at 02:45:53AM +0200, Lars-Peter Clausen wrote:
> > On 06/21/2011 02:14 AM, Mark Brown wrote:
>
> > > I like init, especially considering the plan to add cache support as
> > > there's more work in setting that up once you start doing the advanced
> > > caches.
>
> > If you take a look at other kernel apis _alloc is usually used if the structure
> > is allocated (and initialized) inside the function and _init is used when the
> > function initializes an already existing structure. And it also matches better
>
> That more applies to split alloc/init models - here there's a single
> operation that does both. To me alloc() generally means that it just
> allocates a structure and leaves initialization still to be done while.
>
> > with regmap_free.
>
> That's true.

In the soc-cache code we use _init and _exit respectively. Might be
worth considering instead of _free?

Thanks,
Dimitris