public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Hsiang <Peter.Hsiang@maxim-ic.com>
Cc: Taylor Hutt <thutt@chromium.org>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	Olof Johansson <olofj@chromium.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: codecs: Max98095: Fix logging of hardware revision.
Date: Tue, 21 Jun 2011 02:10:39 +0100	[thread overview]
Message-ID: <20110621011038.GA4322@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <B2150E1E4418E1438554A300EA5040E40DDEC16D42@ITSVLEX06.it.maxim-ic.internal>

On Mon, Jun 20, 2011 at 05:43:58PM -0700, Peter Hsiang wrote:

> I checked with hardware engineering and was told 0x40=RevA, 0x41=RevB..

> Would a raw value or the use of a 0x3F bit mask be more acceptable?

I don't mind (though it does seem like the high bit isn't part of the
actual data), it was just that it's a common error to assume that die
revisions and package revisions correspond directly.

  reply	other threads:[~2011-06-21  1:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-20 18:54 [PATCH] ASoC: codecs: Max98095: Fix logging of hardware revision Taylor Hutt
2011-06-20 20:06 ` Liam Girdwood
2011-06-21  0:23 ` Mark Brown
2011-06-21  0:43   ` Peter Hsiang
2011-06-21  1:10     ` Mark Brown [this message]
2011-06-21 11:55       ` Mark Brown
     [not found]         ` <BANLkTinfL8uSdCvrQYPJb1TQH3HSCu=wAPFZv-AcWRw1_jspXg@mail.gmail.com>
2011-06-21 17:10           ` Mark Brown
2011-06-21 20:16         ` Peter Hsiang
2011-06-21 20:48         ` Peter Hsiang
     [not found]   ` <BANLkTikH6XpGNamh8z4zspxteH3K4mNmew@mail.gmail.com>
2011-06-21 10:06     ` Mark Brown
2011-06-21 23:28 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110621011038.GA4322@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=Peter.Hsiang@maxim-ic.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=olofj@chromium.org \
    --cc=perex@perex.cz \
    --cc=thutt@chromium.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox