Re: [PATCH 2/8] regmap: Add I2C bus support

Mark Brown
2011-06-20T23:41:45Z

On Tue, Jun 21, 2011 at 01:22:55AM +0200, Lars-Peter Clausen wrote:
> On 06/20/2011 02:54 PM, Mark Brown wrote:
> > [...]
> > +
> > +#include <linux/regmap.h>
> > +#include <linux/i2c.h>

> #include <linux/init.h>

For...?

> > +static int regmap_i2c_read(struct device *dev,
> > + const void *reg, size_t reg_size,
> > + void *val, size_t val_size)
> > +{
> > + struct i2c_client *i2c = to_i2c_client(dev);
> > + struct i2c_msg xfer[2];
> > + int ret;

> > + if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_PROTOCOL_MANGLING))
> > + return -ENOTSUPP;

> You shouldn't need I2C_FUNC_PROTOCOL_MANGLING for reading.

Hrm, yeah, probably not.