Re: [PATCH 1/8] regmap: Add generic non-memory mapped register access API

Mark Brown
2011-06-22T19:11:49Z

On Wed, Jun 22, 2011 at 09:03:14PM +0200, Lars-Peter Clausen wrote:
> On 06/22/2011 08:45 PM, Mark Brown wrote:

> > + if (map->bus->read_flag_bit)
> > + u8[0] |= 1 << map->bus->read_flag_bit;

> Should be 1 << (map->bus->read_flag_bit - 1)

The code has the sematic I intended; you can debate if it's the best
semantic and looking at the documentation again it's not entirely clear
so at least that should be updated.