Re: [patch 10/16] sched: throttle entities exceeding their allowed bandwidth

Hidetoshi Seto
2011-06-22T09:39:49Z

(2011/06/21 16:16), Paul Turner wrote:
> Add conditional checks time of put_prev_entity() and enqueue_entity() to detect
> when an active entity has exceeded its allowed bandwidth and requires
> throttling.
>
> Signed-off-by: Paul Turner <pjt@google.com>
>
> ---
(snip)
> @@ -1403,7 +1412,7 @@ static void account_cfs_rq_runtime(struc
> * if we're unable to extend our runtime we resched so that the active
> * hierarchy can be throttled
> */
> - if (!assign_cfs_rq_runtime(cfs_rq))
> + if (!assign_cfs_rq_runtime(cfs_rq) && likely(cfs_rq->curr))
> resched_task(rq_of(cfs_rq)->curr);
> }
>

Nit: I think this hunk could be included in patch 08/16.

The rest is good.

Reviewed-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>

Thanks,
H.Seto