From: Andi Kleen <andi@firstfloor.org>
To: Huang Ying <ying.huang@intel.com>
Cc: Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Tony Luck <tony.luck@intel.com>,
linux-acpi@vger.kernel.org, mjg59@srcf.ucam.org
Subject: Re: [PATCH 1/4] ACPI, APEI, GHES, Prevent GHES to be built as module
Date: Tue, 21 Jun 2011 09:23:01 +0200 [thread overview]
Message-ID: <20110621072301.GA3263@one.firstfloor.org> (raw)
In-Reply-To: <1308640587-24502-2-git-send-email-ying.huang@intel.com>
On Tue, Jun 21, 2011 at 03:16:24PM +0800, Huang Ying wrote:
> GHES (Generic Hardware Error Source) is used to process hardware error
> notification in firmware first mode. But because firmware first mode
> can be turned on but can not be turned off, it is unreasonable to
> unload the GHES module with firmware first mode turned on. To avoid
> confusion, this patch makes GHES can be enable/disable in
> configuration time, but not built as module and unload at run time.
It's better to keep it as a module, but disable unloading.
You can do that with a __module_get(THIS_MODULE) in the init code
when FFM is detected.
-Andi
next prev parent reply other threads:[~2011-06-21 7:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 7:16 [PATCH 0/4] ACPI, APEI, Add APEI related _OSC support Huang Ying
2011-06-21 7:16 ` [PATCH 1/4] ACPI, APEI, GHES, Prevent GHES to be built as module Huang Ying
2011-06-21 7:23 ` Andi Kleen [this message]
2011-06-21 7:30 ` Huang Ying
2011-06-21 13:18 ` Matthew Garrett
2011-06-21 13:23 ` Matthew Garrett
2011-06-21 7:16 ` [PATCH 2/4] ACPI, APEI, GHES, Support disable GHES at boot time Huang Ying
2011-06-21 7:16 ` [PATCH 3/4] ACPI, APEI, Add APEI bit support in generic _OSC call Huang Ying
2011-06-21 7:16 ` [PATCH 4/4] ACPI, APEI, Add APEI _OSC support Huang Ying
2011-06-21 13:22 ` Matthew Garrett
2011-06-22 2:21 ` Huang Ying
2011-06-22 15:49 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621072301.GA3263@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox