Re: [PATCH v2 1/4] Exynos4 NURI: configure regulators and PMIC

Tushar Behera
2011-06-22T03:43:45Z

On Wednesday 22 June 2011 08:01 AM, MyungJoo Ham wrote:
> On Tue, Jun 21, 2011 at 2:33 PM, Tushar Behera<tushar.behera@linaro.org> wrote:
>> On Tuesday 21 June 2011 07:37 AM, MyungJoo Ham wrote:
>>>
>>> Signed-off-by: MyungJoo Ham<myungjoo.ham@samsung.com>
>>> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>>>
>>> --
>>> Changes from v1. Thanks so much for your valuable comments, Mark.
>>> - Removed unnecessary initialization data
>>> - Add __initdata where necessary
>>> - Corrected a regulator name for ADC
>>> ---
>>> arch/arm/mach-exynos4/mach-nuri.c | 622
>>> ++++++++++++++++++++++++++++++++++++-
>>> 1 files changed, 621 insertions(+), 1 deletions(-)
>>>
>> Will it be possible to move PMIC specific defines to a common file and make
>> appropriate calls in the board-specific file?
>>
>> In that way, we can re-use this PMIC code on some other boards (e.g.
>> Insignal low-cost board Origen featuring Exynos4210 also features MAX8997).
>>
>
> Yes, we have tried creating PMIC defines at a seperated file in our
> local repositories (still doing so in those repositories).
> However, that ended up creating multiple PMIC defines (one PMIC define
> file for each board); the connections between LDO# and devices are
> different.
>
In that case, we can first post the Origen board support and PMIC code
on the ML, then we would see if we can consolidate.

That looks more logical as per Mark's suggestion also.
>>
>> --
>> Tushar Behera
>>
>
>

--
Tushar Behera