public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
	Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] jump_label: fix jump_label update
Date: Tue, 21 Jun 2011 11:44:58 -0400	[thread overview]
Message-ID: <20110621154458.GB2495@redhat.com> (raw)
In-Reply-To: <4E00038B.2060404@cn.fujitsu.com>

On Tue, Jun 21, 2011 at 10:35:55AM +0800, Xiao Guangrong wrote:
> The key of module is out of __stop___jump_table, it causes the events
> of modules does not work
> 
> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> ---
>  kernel/jump_label.c |   14 +++++++++-----
>  1 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/jump_label.c b/kernel/jump_label.c
> index fa27e75..a8ce450 100644
> --- a/kernel/jump_label.c
> +++ b/kernel/jump_label.c
> @@ -375,15 +375,19 @@ int jump_label_text_reserved(void *start, void *end)
>  
>  static void jump_label_update(struct jump_label_key *key, int enable)
>  {
> -	struct jump_entry *entry = key->entries;
> -
> -	/* if there are no users, entry can be NULL */
> -	if (entry)
> -		__jump_label_update(key, entry, __stop___jump_table, enable);
> +	struct jump_entry *entry = key->entries, *stop = __stop___jump_table;
>  
>  #ifdef CONFIG_MODULES
> +	struct module *mod = __module_address((jump_label_t)key);
> +
>  	__jump_label_mod_update(key, enable);
> +
> +	if (mod)
> +		stop = mod->jump_entries + mod->num_jump_entries;
>  #endif
> +	/* if there are no users, entry can be NULL */
> +	if (entry)
> +		__jump_label_update(key, entry, stop, enable);
>  }
>  
>  #endif
> -- 
> 1.7.5.4

Looks good. Thanks for the fix!

Acked-by: Jason Baron <jbaron@redhat.com>

-Jason

  parent reply	other threads:[~2011-06-21 15:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21  2:35 [PATCH v2] jump_label: fix jump_label update Xiao Guangrong
2011-06-21  9:44 ` Jiri Olsa
2011-06-21 15:47   ` Jason Baron
2011-06-21 15:44 ` Jason Baron [this message]
2011-06-23 12:22 ` Avi Kivity
2011-06-23 12:45   ` Avi Kivity
2011-06-23 17:44     ` Steven Rostedt
2011-07-01 15:12 ` [tip:perf/urgent] jump_label: Fix jump_label update for modules tip-bot for Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110621154458.GB2495@redhat.com \
    --to=jbaron@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=xiaoguangrong@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox