public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Stephane Eranian <eranian@google.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Don Zickus <dzickus@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	Lin Ming <ming.m.lin@intel.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Vince Weaver <vweaver1@eecs.utk.edu>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] perf, x86: Add PERF_COUNT_HW_NMI_WATCHDOG event v2
Date: Tue, 21 Jun 2011 21:23:19 +0400	[thread overview]
Message-ID: <20110621172319.GE21641@sun> (raw)
In-Reply-To: <BANLkTink5nOTqvqQYr4kx0fnBoOpoq7CiQ@mail.gmail.com>

On Tue, Jun 21, 2011 at 07:10:05PM +0200, Stephane Eranian wrote:
...
> >
> >  The key here is that we use that named non-sleeping ticks (as oprofile
> > did) for nmi-watchdog and it allows us to free "cpu-cycles" counter for
> > user needs. Of course we pick up one counter for this but it doesn't intersect
> > with "cpu-cycles" counter (because counters are grouped and can count only
> > specified events in each group). Stepane, should I post more details?
> >
> Ok, so you're using a different PMU event for the watchdog. But then, in this
> case why not simply change kernel/watchdog.c to hardcode something specific
> for P4, i.e, change the wd_hw_attr.config/type fields to match the
> event you want.

  It doesn't change things much. Of course I can put some specifics into
.config but where is the guarantee some new generic event would not ever
intersect with it. I know (for example) we could reserve -1ULL for this
event but again where is the guarantee that it will never ever be used
system wide in future for some different event?

So I need some event-id in which I may be sure it will never be
used for different purpose.

> You could create a arch specific callback to setup config/type.
> 
> I don't think it makes sense to expose yet another generic PMU event, especially
> given the name you gave to it and what it actually does. People might wonder
> what good is that for?

	Cyrill

  reply	other threads:[~2011-06-21 17:23 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28 15:37 [RFC -tip] perf, x86: Add PERF_COUNT_HW_NMI_WATCHDOG event v2 Cyrill Gorcunov
2011-06-21 15:23 ` Don Zickus
2011-06-21 15:40   ` Cyrill Gorcunov
2011-06-21 15:58     ` Peter Zijlstra
2011-06-21 16:13       ` Cyrill Gorcunov
2011-06-21 16:20         ` Stephane Eranian
2011-06-21 16:48           ` Cyrill Gorcunov
2011-06-21 17:02             ` Cyrill Gorcunov
2011-06-21 17:10             ` Stephane Eranian
2011-06-21 17:23               ` Cyrill Gorcunov [this message]
2011-06-21 17:26                 ` Stephane Eranian
2011-06-21 17:54                   ` Cyrill Gorcunov
2011-06-21 18:06                     ` Stephane Eranian
2011-06-21 18:32                       ` Cyrill Gorcunov
2011-06-22  8:27                         ` Cyrill Gorcunov
2011-06-22  9:21                           ` Cyrill Gorcunov
2011-06-23  6:48                             ` Cyrill Gorcunov
2011-06-23  9:40                               ` Stephane Eranian
2011-06-23  9:54                                 ` Cyrill Gorcunov
2011-06-23 11:07                                   ` Cyrill Gorcunov
2011-06-23 11:40                                     ` Don Zickus
2011-06-23 11:44                                       ` Stephane Eranian
2011-06-23 11:53                                         ` Cyrill Gorcunov
2011-06-23 12:03                                           ` Stephane Eranian
2011-06-23 12:07                                             ` Cyrill Gorcunov
2011-06-23 12:26                                               ` Cyrill Gorcunov
2011-06-23 12:31                                                 ` Stephane Eranian
2011-06-23 12:34                                                   ` Cyrill Gorcunov
2011-06-23 11:51                                       ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110621172319.GE21641@sun \
    --to=gorcunov@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=mingo@elte.hu \
    --cc=vweaver1@eecs.utk.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox