From: Samuel Ortiz <sameo@linux.intel.com>
To: Kevin Hilman <khilman@ti.com>
Cc: Felipe Balbi <balbi@ti.com>,
Keshava Munegowda <keshava_mgowda@ti.com>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, gadiyar@ti.com,
parthab@india.ti.com
Subject: Re: [PATCH] mfd: omap: fix the crash during omap ehci or ohci driver initialization
Date: Tue, 21 Jun 2011 19:53:59 +0200 [thread overview]
Message-ID: <20110621175359.GA22420@sortiz-mobl> (raw)
In-Reply-To: <87liww6tva.fsf@ti.com>
Hi Kevin,
On Mon, Jun 20, 2011 at 03:06:01PM -0700, Kevin Hilman wrote:
> Samuel Ortiz <sameo@linux.intel.com> writes:
>
> > Hi Felipe,
> >
> > On Mon, Jun 20, 2011 at 04:28:52PM +0300, Felipe Balbi wrote:
> >> Hi,
> >>
> >> On Mon, Jun 20, 2011 at 03:26:26PM +0200, Samuel Ortiz wrote:
> >> > On Mon, Jun 06, 2011 at 07:12:19PM +0530, Keshava Munegowda wrote:
> >> > > From: Keshava Munegowda <Keshava_mgowda@ti.com>
> >> > >
> >> > > Oops are produced during initialization of ehci and ohci
> >> > > drivers. This is because the run time pm apis are used by
> >> > > the driver but the corresponding hwmod structures and
> >> > > initialization is not merged.
> >> > You mean they're currently checked in a different tree ? Is that a
> >> > public one?
> >>
> >> it was supposed to go via linux-omap tree but the patches got lost in
> >> the limbo :-(
> > Then shouldn't those patches be the ones to be sent to Linus as a fix for 3.0 ?
>
> If they were ready, maybe. But those patches still need important work
> (and review) and are not "fix" material but need to wait until the next
> merge window.
Fair enough.
> Basically, the original patch should not have been submitted to mainline
> until the runtime PM support was ready, so the correct short term fix is
> to simply revert.
>
> Also, to echo the question from Dima Zavin:
>
> Why isn't this just a simple revert of the original patch?
I did a revert in my tree.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2011-06-21 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 13:42 [PATCH] mfd: omap: fix the crash during omap ehci or ohci driver initialization Keshava Munegowda
2011-06-06 13:52 ` Felipe Balbi
2011-06-15 23:25 ` Dima Zavin
2011-06-20 13:26 ` Samuel Ortiz
2011-06-20 13:28 ` Felipe Balbi
2011-06-20 14:59 ` Samuel Ortiz
2011-06-20 22:06 ` Kevin Hilman
2011-06-20 22:13 ` Felipe Balbi
2011-06-21 17:53 ` Samuel Ortiz [this message]
2011-06-21 20:27 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621175359.GA22420@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=balbi@ti.com \
--cc=gadiyar@ti.com \
--cc=keshava_mgowda@ti.com \
--cc=khilman@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=parthab@india.ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox