[GIT PULL] oprofile fixes for v3.0

[GIT PULL] oprofile fixes for v3.0

[Robert Richter]

Ingo,

please pull oprofile fixes for v3.0 (tip/perf/urgent):

 git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent

Thanks,

-Robert


The following changes since commit 2c53b436a30867eb6b47dd7bab23ba638d1fb0d2:

  Linux 3.0-rc3 (2011-06-13 15:29:59 -0700)

are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent

Robert Richter (2):
      oprofile, x86: Fix race in nmi handler while starting counters
      oprofile, x86: Fix nmi-unsafe callgraph support

 arch/x86/oprofile/backtrace.c |   56 ++++++++++++++++++++++++++++++++++------
 arch/x86/oprofile/nmi_int.c   |   14 +++++++---
 2 files changed, 57 insertions(+), 13 deletions(-)


-- 
Advanced Micro Devices, Inc.
Operating System Research Center

Re: [GIT PULL] oprofile fixes for v3.0

[Ingo Molnar]

Robert,

* Robert Richter <robert.richter@amd.com> wrote:

> Ingo,
> 
> please pull oprofile fixes for v3.0 (tip/perf/urgent):
> 
>  git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> 
> Thanks,
> 
> -Robert
> 
> 
> The following changes since commit 2c53b436a30867eb6b47dd7bab23ba638d1fb0d2:
> 
>   Linux 3.0-rc3 (2011-06-13 15:29:59 -0700)
> 
> are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> 
> Robert Richter (2):
>       oprofile, x86: Fix race in nmi handler while starting counters
>       oprofile, x86: Fix nmi-unsafe callgraph support
> 
>  arch/x86/oprofile/backtrace.c |   56 ++++++++++++++++++++++++++++++++++------
>  arch/x86/oprofile/nmi_int.c   |   14 +++++++---
>  2 files changed, 57 insertions(+), 13 deletions(-)

Since when has NMI callgraph support been broken?

Thanks,

	Ingo

Re: [GIT PULL] oprofile fixes for v3.0

[Robert Richter]

On 21.06.11 09:03:08, Ingo Molnar wrote:
> 
> Robert,
> 
> * Robert Richter <robert.richter@amd.com> wrote:
> 
> > Ingo,
> > 
> > please pull oprofile fixes for v3.0 (tip/perf/urgent):
> > 
> >  git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> > 
> > Thanks,
> > 
> > -Robert
> > 
> > 
> > The following changes since commit 2c53b436a30867eb6b47dd7bab23ba638d1fb0d2:
> > 
> >   Linux 3.0-rc3 (2011-06-13 15:29:59 -0700)
> > 
> > are available in the git repository at:
> >   git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> > 
> > Robert Richter (2):
> >       oprofile, x86: Fix race in nmi handler while starting counters
> >       oprofile, x86: Fix nmi-unsafe callgraph support
> > 
> >  arch/x86/oprofile/backtrace.c |   56 ++++++++++++++++++++++++++++++++++------
> >  arch/x86/oprofile/nmi_int.c   |   14 +++++++---
> >  2 files changed, 57 insertions(+), 13 deletions(-)
> 
> Since when has NMI callgraph support been broken?

I think it never worked correct. But the patch can be backported
without conflicts/reworks only for .37 stable kernel. Do you rather
like to take it for v3.1?

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

Re: [GIT PULL] oprofile fixes for v3.0

[Ingo Molnar]

* Robert Richter <robert.richter@amd.com> wrote:

> On 21.06.11 09:03:08, Ingo Molnar wrote:
> > 
> > Robert,
> > 
> > * Robert Richter <robert.richter@amd.com> wrote:
> > 
> > > Ingo,
> > > 
> > > please pull oprofile fixes for v3.0 (tip/perf/urgent):
> > > 
> > >  git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> > > 
> > > Thanks,
> > > 
> > > -Robert
> > > 
> > > 
> > > The following changes since commit 2c53b436a30867eb6b47dd7bab23ba638d1fb0d2:
> > > 
> > >   Linux 3.0-rc3 (2011-06-13 15:29:59 -0700)
> > > 
> > > are available in the git repository at:
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> > > 
> > > Robert Richter (2):
> > >       oprofile, x86: Fix race in nmi handler while starting counters
> > >       oprofile, x86: Fix nmi-unsafe callgraph support
> > > 
> > >  arch/x86/oprofile/backtrace.c |   56 ++++++++++++++++++++++++++++++++++------
> > >  arch/x86/oprofile/nmi_int.c   |   14 +++++++---
> > >  2 files changed, 57 insertions(+), 13 deletions(-)
> > 
> > Since when has NMI callgraph support been broken?
> 
> I think it never worked correct. But the patch can be backported 
> without conflicts/reworks only for .37 stable kernel. Do you rather 
> like to take it for v3.1?

Yeah, v3.1 would be fine - if it was broken for like 5-10 years then 
it's not eligible for -rc5. The linecount is very high as well, it's 
definitely not a oneliner fix ...

Thanks,

	Ingo

Re: [GIT PULL] oprofile fixes for v3.0

[Robert Richter]

On 21.06.11 16:18:40, Ingo Molnar wrote:

> > I think it never worked correct. But the patch can be backported 
> > without conflicts/reworks only for .37 stable kernel. Do you rather 
> > like to take it for v3.1?
> 
> Yeah, v3.1 would be fine - if it was broken for like 5-10 years then 
> it's not eligible for -rc5. The linecount is very high as well, it's 
> definitely not a oneliner fix ...

Ingo,

I dropped this patch, there is only one fix now. Please pull again
from:

 git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git for-tip

Thanks,

-Robert



The following changes since commit 2c53b436a30867eb6b47dd7bab23ba638d1fb0d2:

  Linux 3.0-rc3 (2011-06-13 15:29:59 -0700)

are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git for-tip

Robert Richter (1):
      oprofile, x86: Fix race in nmi handler while starting counters

 arch/x86/oprofile/nmi_int.c |   14 ++++++++++----
 1 files changed, 10 insertions(+), 4 deletions(-)



-- 
Advanced Micro Devices, Inc.
Operating System Research Center

[PATCH 0/3] oprofile fixes for 3.0

[Robert Richter]

Some fixes for 3.0 for review. Will apply them later and send a pull
request.

Thanks

-Robert


The following changes since commit cbf74cea070fa1f705de4712e25d9e56ae6543c7:

  oprofile, x86: Add comments to IBS LVT offset initialization (2011-05-30 16:36:54 +0200)

Robert Richter (3):
      oprofile: Free potentially owned tasks in case of errors
      oprofile: Fix locking dependency in sync_start()
      oprofile, dcookies: Fix possible circular locking dependency

 drivers/oprofile/buffer_sync.c |   21 +++++++++++----------
 fs/dcookies.c                  |    3 +++
 2 files changed, 14 insertions(+), 10 deletions(-)

[GIT PULL] oprofile fixes for v3.0

[Robert Richter]

Ingo,

please pull oprofile fixes for v3.0 (tip/perf/urgent):

 git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent

Thanks,

-Robert


The following changes since commit d7ebe75b065a7c2d58ffc12f9d2e00d5ea4e71eb:

  perf: Fix comments in include/linux/perf_event.h (2011-06-04 12:31:14 +0200)

are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent

Robert Richter (4):
      oprofile, x86: Add comments to IBS LVT offset initialization
      oprofile: Free potentially owned tasks in case of errors
      oprofile: Fix locking dependency in sync_start()
      oprofile, dcookies: Fix possible circular locking dependency

 arch/x86/kernel/apic/apic.c      |    3 ++-
 arch/x86/oprofile/op_model_amd.c |   13 +++++++++----
 drivers/oprofile/buffer_sync.c   |   21 +++++++++++----------
 fs/dcookies.c                    |    3 +++
 4 files changed, 25 insertions(+), 15 deletions(-)

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

Re: [GIT PULL] oprofile fixes for v3.0

[Ingo Molnar]

* Robert Richter <robert.richter@amd.com> wrote:

> Ingo,
> 
> please pull oprofile fixes for v3.0 (tip/perf/urgent):
> 
>  git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> 
> Thanks,
> 
> -Robert
> 
> 
> The following changes since commit d7ebe75b065a7c2d58ffc12f9d2e00d5ea4e71eb:
> 
>   perf: Fix comments in include/linux/perf_event.h (2011-06-04 12:31:14 +0200)
> 
> are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> 
> Robert Richter (4):
>       oprofile, x86: Add comments to IBS LVT offset initialization
>       oprofile: Free potentially owned tasks in case of errors
>       oprofile: Fix locking dependency in sync_start()
>       oprofile, dcookies: Fix possible circular locking dependency
> 
>  arch/x86/kernel/apic/apic.c      |    3 ++-
>  arch/x86/oprofile/op_model_amd.c |   13 +++++++++----
>  drivers/oprofile/buffer_sync.c   |   21 +++++++++++----------
>  fs/dcookies.c                    |    3 +++
>  4 files changed, 25 insertions(+), 15 deletions(-)

Pulled, thanks a lot Robert!

	Ingo

Re: [GIT PULL] oprofile fixes for v3.0

[Robert Richter]

On 08.06.11 10:06:31, Ingo Molnar wrote:
> 
> * Robert Richter <robert.richter@amd.com> wrote:
> 
> > Ingo,
> > 
> > please pull oprofile fixes for v3.0 (tip/perf/urgent):
> > 
> >  git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> > 
> > Thanks,
> > 
> > -Robert
> > 
> > 
> > The following changes since commit d7ebe75b065a7c2d58ffc12f9d2e00d5ea4e71eb:
> > 
> >   perf: Fix comments in include/linux/perf_event.h (2011-06-04 12:31:14 +0200)
> > 
> > are available in the git repository at:
> >   git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> > 
> > Robert Richter (4):
> >       oprofile, x86: Add comments to IBS LVT offset initialization

Ingo,

it seems you pulled (86dd7909c2c4ae3f219a9233bf0f095b05632ecf) from

 cbf74cea070fa1f705de4712e25d9e56ae6543c7 (oprofile, x86: Add comments to IBS LVT offset initialization)

These ones are still missing:

> >       oprofile: Free potentially owned tasks in case of errors
> >       oprofile: Fix locking dependency in sync_start()
> >       oprofile, dcookies: Fix possible circular locking dependency

But oprofile/urgent is

 fe47ae7f53e179d2ef6771024feb000cbb86640f (oprofile, dcookies: Fix possible circular locking dependency)

Is this intended? Maybe a korg git sync issue?

Thanks,

-Robert

> > 
> >  arch/x86/kernel/apic/apic.c      |    3 ++-
> >  arch/x86/oprofile/op_model_amd.c |   13 +++++++++----
> >  drivers/oprofile/buffer_sync.c   |   21 +++++++++++----------
> >  fs/dcookies.c                    |    3 +++
> >  4 files changed, 25 insertions(+), 15 deletions(-)
> 
> Pulled, thanks a lot Robert!
> 
> 	Ingo
> 

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

Re: [GIT PULL] oprofile fixes for v3.0

[Ingo Molnar]

* Robert Richter <robert.richter@amd.com> wrote:

> On 08.06.11 10:06:31, Ingo Molnar wrote:
> > 
> > * Robert Richter <robert.richter@amd.com> wrote:
> > 
> > > Ingo,
> > > 
> > > please pull oprofile fixes for v3.0 (tip/perf/urgent):
> > > 
> > >  git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> > > 
> > > Thanks,
> > > 
> > > -Robert
> > > 
> > > 
> > > The following changes since commit d7ebe75b065a7c2d58ffc12f9d2e00d5ea4e71eb:
> > > 
> > >   perf: Fix comments in include/linux/perf_event.h (2011-06-04 12:31:14 +0200)
> > > 
> > > are available in the git repository at:
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git urgent
> > > 
> > > Robert Richter (4):
> > >       oprofile, x86: Add comments to IBS LVT offset initialization
> 
> Ingo,
> 
> it seems you pulled (86dd7909c2c4ae3f219a9233bf0f095b05632ecf) from
> 
>  cbf74cea070fa1f705de4712e25d9e56ae6543c7 (oprofile, x86: Add comments to IBS LVT offset initialization)
> 
> These ones are still missing:
> 
> > >       oprofile: Free potentially owned tasks in case of errors
> > >       oprofile: Fix locking dependency in sync_start()
> > >       oprofile, dcookies: Fix possible circular locking dependency
> 
> But oprofile/urgent is
> 
>  fe47ae7f53e179d2ef6771024feb000cbb86640f (oprofile, dcookies: Fix possible circular locking dependency)
> 
> Is this intended? Maybe a korg git sync issue?

Yeah, probably - and i reviewed the on-lkml patches you sent earlier 
and didnt notice that these three are missing from the pull request. 
I pulled again and the bits are there now.

Thanks,

	Ingo