From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Deep Debroy <ddebroy@gmail.com>
Cc: linux-kernel@vger.kernel.org, kraxel@redhat.com
Subject: Re: code sections beyond .text skipped from alternatives_smp_module_add
Date: Wed, 22 Jun 2011 09:21:14 -0400 [thread overview]
Message-ID: <20110622132114.GA8656@dumpdata.com> (raw)
In-Reply-To: <BANLkTikyjzQ-VZMn2_ZobEmHMLRafki9YQ@mail.gmail.com>
> > Looking at the code, in module_finalize for x86, only .text seems to
> > be getting picked for the patching of lock prefixes while other
> > sections such as .exit.text or .init.text are not. Is there a reason
> > we skip the other *.text code sections from the lock patches? Would
> + Gerd Hoffmann who introduced the SMP patching code below back in Jan
> 2006 as part of 2.6.15.
Whoa, long time ago.
>
> Any comments on why patching of smp_lock prefixes should be restricted
> to .text and not other *.text code sections?
It could be that at that time the .exit.text or .init.text did not exist.
As in, the patching code just hasn't kept up. One way of checking that
is just finding the ancient 2.6.15 code and seeing if there is any
mention of those extra segments.
Do you have a patch to fix this?
next prev parent reply other threads:[~2011-06-22 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 8:10 code sections beyond .text skipped from alternatives_smp_module_add Deep Debroy
2011-06-21 18:08 ` Deep Debroy
2011-06-22 13:21 ` Konrad Rzeszutek Wilk [this message]
2011-06-22 17:27 ` Deep Debroy
2011-06-22 21:58 ` Deep Debroy
2011-06-22 23:45 ` Randy Dunlap
2011-06-23 5:03 ` Deep Debroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110622132114.GA8656@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=ddebroy@gmail.com \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox