From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Huang Ying <ying.huang@intel.com>
Cc: Len Brown <lenb@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
"Luck, Tony" <tony.luck@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 4/4] ACPI, APEI, Add APEI _OSC support
Date: Wed, 22 Jun 2011 16:49:48 +0100 [thread overview]
Message-ID: <20110622154948.GA3219@srcf.ucam.org> (raw)
In-Reply-To: <4E0151A0.90505@intel.com>
On Wed, Jun 22, 2011 at 10:21:20AM +0800, Huang Ying wrote:
> At least on some of my testing machine, generic _OSC call will not
> return any error even it does not support APEI bit. So I think
> sometimes it may be helpful to printk something here. To avoid
> confusion, can we change the message as follow.
>
> - generic _OSC succeeded, APEI _OSC failed: APEI firmware first mode is
> enabled by APEI bit.
> - generic _OSC failed, APEI _OSC succeeded: APEI firmware first mode is
> enabled by APEI _OSC.
"WHEA _OSC", I think. The UUID here is part of the Microsoft spec, not
the APEI one.
> - both succeeded: APEI firmware first mode is enabled by APEI bit and
> APEI _OSC.
> - both failed: Failed to enable APEI firmware first mode!
Otherwise, looks good.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2011-06-22 15:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 7:16 [PATCH 0/4] ACPI, APEI, Add APEI related _OSC support Huang Ying
2011-06-21 7:16 ` [PATCH 1/4] ACPI, APEI, GHES, Prevent GHES to be built as module Huang Ying
2011-06-21 7:23 ` Andi Kleen
2011-06-21 7:30 ` Huang Ying
2011-06-21 13:18 ` Matthew Garrett
2011-06-21 13:23 ` Matthew Garrett
2011-06-21 7:16 ` [PATCH 2/4] ACPI, APEI, GHES, Support disable GHES at boot time Huang Ying
2011-06-21 7:16 ` [PATCH 3/4] ACPI, APEI, Add APEI bit support in generic _OSC call Huang Ying
2011-06-21 7:16 ` [PATCH 4/4] ACPI, APEI, Add APEI _OSC support Huang Ying
2011-06-21 13:22 ` Matthew Garrett
2011-06-22 2:21 ` Huang Ying
2011-06-22 15:49 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110622154948.GA3219@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=andi@firstfloor.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox