public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wim Van Sebroeck <wim@iguana.be>
To: Arnd Bergmann <arnd@arndb.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux Watchdog Mailing List <linux-watchdog@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 8/10 v2] Generic Watchdog Timer Driver
Date: Wed, 22 Jun 2011 22:00:09 +0200	[thread overview]
Message-ID: <20110622200009.GC26745@infomag.iguana.be> (raw)
In-Reply-To: <201106182109.14520.arnd@arndb.de>

Hi Arnd,

> On Saturday 18 June 2011 19:26:37 Wim Van Sebroeck wrote:
> > 
> > watchdog: WatchDog Timer Driver Core - Part 8
> >    
> > Add support for a parent device so that it can
> > be set as the parent of the misc_device.
> > 
> > Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
> How about folding this patch into the first one? It hardly adds any code 
> as much as it replaces some lines with others.

prefer to not do that for following reasons:
1) I deliberately splitted the framework in a series of patches, so that people
understand better what the differen developmentt steps have been historically
and/or logically. By splitting it, I hope that people will understand better
why the API is what it is.
2) most watchdog drivers don't do this yet. So this teaches existing device
driver writers also that this is a possible feature.

Kind regards,
Wim.


  reply	other threads:[~2011-06-22 20:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-18 17:26 [PATCH 8/10 v2] Generic Watchdog Timer Driver Wim Van Sebroeck
2011-06-18 19:09 ` Arnd Bergmann
2011-06-22 20:00   ` Wim Van Sebroeck [this message]
2011-06-24 13:49     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110622200009.GC26745@infomag.iguana.be \
    --to=wim@iguana.be \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox