From: Jean Delvare <khali@linux-fr.org>
To: Ankur Patel <bkankur@gmail.com>
Cc: Guenter Roeck <guenter.roeck@ericsson.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data
Date: Thu, 23 Jun 2011 10:45:25 +0200 [thread overview]
Message-ID: <20110623104525.30718cd7@endymion.delvare> (raw)
In-Reply-To: <BANLkTikLSmXKG67NroavRb+FjzVE5ie21Q@mail.gmail.com>
On Thu, 23 Jun 2011 13:56:53 +0530, Ankur Patel wrote:
> On Thu, Jun 23, 2011 at 1:36 PM, Jean Delvare <khali@linux-fr.org> wrote:
>
> > On Wed, 22 Jun 2011 07:51:39 +0530, Ankur Patel wrote:
> > > From: Ankur Patel <ankur.patel@quipment.in>
> > >
> > > In the tmp102.ko driver support for 12 bit data is added. Also, the
> > > sysfs names are replaced with the actual chip supported fuctionality
> > > names.
> >
> > Nack. These attribute names are standard, see
> > Documentation/hwmon/sysfs-interface. You don't get to change them.
> >
> >
> > What problem were you trying to solve? libsensors expects the attribute
> > names which are in use today.
> >
> > Agree, But using temp1_max_hyst as an attribute for presenting low level
> threshold, will it not more feasible to use temp1_low instead?.
No. This isn't a min temperature limit. Please read the TMP102
datasheet and in particular Figure 10 "Output Transfer Function
Diagrams" and the description of the AL configuration bit.
--
Jean Delvare
next prev parent reply other threads:[~2011-06-23 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 2:21 [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data Ankur Patel
2011-06-23 8:06 ` Jean Delvare
[not found] ` <BANLkTikLSmXKG67NroavRb+FjzVE5ie21Q@mail.gmail.com>
2011-06-23 8:45 ` Jean Delvare [this message]
[not found] ` <BANLkTikYbpeSbt5VHndJnsWXax1MX+Xk-w@mail.gmail.com>
2011-06-23 9:08 ` Jean Delvare
2011-06-23 9:26 ` Ankur Patel
-- strict thread matches above, loose matches on Subject: below --
2011-06-22 4:28 Ankur Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110623104525.30718cd7@endymion.delvare \
--to=khali@linux-fr.org \
--cc=bkankur@gmail.com \
--cc=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox