From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759074Ab1FWJIW (ORCPT ); Thu, 23 Jun 2011 05:08:22 -0400 Received: from zone0.gcu-squad.org ([212.85.147.21]:32404 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754867Ab1FWJIV (ORCPT ); Thu, 23 Jun 2011 05:08:21 -0400 Date: Thu, 23 Jun 2011 11:08:10 +0200 From: Jean Delvare To: Ankur Patel Cc: Guenter Roeck , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data Message-ID: <20110623110810.6aab0072@endymion.delvare> In-Reply-To: References: <1308709299-24539-1-git-send-email-bkankur@gmail.com> <20110623100616.4573741f@endymion.delvare> <20110623104525.30718cd7@endymion.delvare> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.20.1; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Jun 2011 14:35:31 +0530, Ankur Patel wrote: > On Thu, Jun 23, 2011 at 2:15 PM, Jean Delvare wrote: > > > On Thu, 23 Jun 2011 13:56:53 +0530, Ankur Patel wrote: > > > On Thu, Jun 23, 2011 at 1:36 PM, Jean Delvare > > wrote: > > > > > > > On Wed, 22 Jun 2011 07:51:39 +0530, Ankur Patel wrote: > > > > > From: Ankur Patel > > > > > > > > > > In the tmp102.ko driver support for 12 bit data is added. Also, the > > > > > sysfs names are replaced with the actual chip supported fuctionality > > > > > names. > > > > > > > > Nack. These attribute names are standard, see > > > > Documentation/hwmon/sysfs-interface. You don't get to change them. > > > > > > > > > > > > What problem were you trying to solve? libsensors expects the attribute > > > > names which are in use today. > > > > > > > > Agree, But using temp1_max_hyst as an attribute for presenting low > > level > > > threshold, will it not more feasible to use temp1_low instead?. > > > > No. This isn't a min temperature limit. Please read the TMP102 > > datasheet and in particular Figure 10 "Output Transfer Function > > Diagrams" and the description of the AL configuration bit. > > > > Understood. Thank you. I am reverting back the changes for sysfs attribute > names in the submitted patch to original. Do you have other Issue apart from > that? I didn't read the patch, only the header. So I don't know yet. Just resubmit and wait for review. -- Jean Delvare