From: Paul Mundt <lethal@linux-sh.org>
To: Pavel Shved <shved@ispras.ru>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@ispras.ru
Subject: Re: [PATCH] hecubafb: add module_put on error path in hecubafb_probe()
Date: Fri, 24 Jun 2011 17:02:16 +0900 [thread overview]
Message-ID: <20110624080215.GB24184@linux-sh.org> (raw)
In-Reply-To: <1308327913-23220-3-git-send-email-shved@ispras.ru>
On Fri, Jun 17, 2011 at 08:25:12PM +0400, Pavel Shved wrote:
> In hecubafb_probe(), after a successful try_module_get, vzalloc may
> fail and make the hecubafb_probe return, but the module is not put on
> this error path.
>
> This patch adds an exit point that calls module_put in such situation.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Pavel Shved <shved@ispras.ru>
Applied, thanks.
next prev parent reply other threads:[~2011-06-24 8:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 16:25 [PATCH] farsync: add module_put to error path in fst_open() Pavel Shved
2011-06-17 16:25 ` [PATCH] gigaset: call module_put before restart of if_open() Pavel Shved
2011-06-17 19:28 ` David Miller
2011-06-17 16:25 ` [PATCH] hecubafb: add module_put on error path in hecubafb_probe() Pavel Shved
2011-06-24 8:02 ` Paul Mundt [this message]
2011-06-17 16:25 ` [PATCH] synclink_gt: add module_put on error path in hdlcdev_open() Pavel Shved
2011-06-17 19:28 ` [PATCH] farsync: add module_put to error path in fst_open() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110624080215.GB24184@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=ldv-project@ispras.ru \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shved@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox