From: Oleg Nesterov <oleg@redhat.com>
To: Tejun Heo <tj@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: vda.linux@googlemail.com, jan.kratochvil@redhat.com,
pedro@codesourcery.com, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] ptrace: kill real_parent_is_ptracer() in in favor of ptrace_reparented()
Date: Fri, 24 Jun 2011 17:34:23 +0200 [thread overview]
Message-ID: <20110624153423.GC9346@redhat.com> (raw)
In-Reply-To: <20110624153330.GA9346@redhat.com>
Kill real_parent_is_ptracer() and update the callers to use
ptrace_reparented(), after the previous patch they do the same.
Remove the unnecessary ->ptrace != 0 check in get_signal_to_deliver(),
if ptrace_reparented() == T then the task must be ptraced.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
kernel/signal.c | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
--- ptrace/kernel/signal.c~10_kill_real_parent_is_ptracer 2011-06-24 16:53:25.000000000 +0200
+++ ptrace/kernel/signal.c 2011-06-24 16:59:20.000000000 +0200
@@ -1760,15 +1760,6 @@ static int sigkill_pending(struct task_s
}
/*
- * Test whether the target task of the usual cldstop notification - the
- * real_parent of @child - is in the same group as the ptracer.
- */
-static bool real_parent_is_ptracer(struct task_struct *child)
-{
- return same_thread_group(child->parent, child->real_parent);
-}
-
-/*
* This must be called with current->sighand->siglock held.
*
* This should be the path for all ptrace stops.
@@ -1848,7 +1839,7 @@ static void ptrace_stop(int exit_code, i
* separately unless they're gonna be duplicates.
*/
do_notify_parent_cldstop(current, true, why);
- if (gstop_done && !real_parent_is_ptracer(current))
+ if (gstop_done && ptrace_reparented(current))
do_notify_parent_cldstop(current, false, why);
/*
@@ -2154,7 +2145,6 @@ relock:
* the CLD_ si_code into SIGNAL_CLD_MASK bits.
*/
if (unlikely(signal->flags & SIGNAL_CLD_MASK)) {
- struct task_struct *leader;
int why;
if (signal->flags & SIGNAL_CLD_CONTINUED)
@@ -2175,13 +2165,11 @@ relock:
* a duplicate.
*/
read_lock(&tasklist_lock);
-
do_notify_parent_cldstop(current, false, why);
- leader = current->group_leader;
- if (leader->ptrace && !real_parent_is_ptracer(leader))
- do_notify_parent_cldstop(leader, true, why);
-
+ if (ptrace_reparented(current->group_leader))
+ do_notify_parent_cldstop(current->group_leader,
+ true, why);
read_unlock(&tasklist_lock);
goto relock;
next prev parent reply other threads:[~2011-06-24 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 15:33 [PATCH 0/3] ptrace_reparented fixes/cleanups Oleg Nesterov
2011-06-24 15:34 ` [PATCH 1/3] ptrace: ptrace_reparented() should check same_thread_group() Oleg Nesterov
2011-06-25 13:43 ` Tejun Heo
2011-06-26 21:08 ` Oleg Nesterov
2011-06-24 15:34 ` Oleg Nesterov [this message]
2011-06-25 13:49 ` [PATCH 2/3] ptrace: kill real_parent_is_ptracer() in in favor of ptrace_reparented() Tejun Heo
2011-06-24 15:34 ` [PATCH 3/3] ptrace: wait_consider_task: s/same_thread_group/ptrace_reparented/ Oleg Nesterov
2011-06-25 13:52 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110624153423.GC9346@redhat.com \
--to=oleg@redhat.com \
--cc=jan.kratochvil@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pedro@codesourcery.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox