public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vasiliy Kulikov <segoon@openwall.com>
To: Balbir Singh <bsingharora@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	David Rientjes <rientjes@google.com>,
	Stephen Wilson <wilsons@start.ca>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	security@kernel.org, Eric Paris <eparis@redhat.com>,
	Solar Designer <solar@openwall.com>
Subject: Re: [PATCH 1/2] proc: restrict access to /proc/PID/io
Date: Tue, 28 Jun 2011 11:50:27 +0400	[thread overview]
Message-ID: <20110628075027.GA4051@albatros> (raw)
In-Reply-To: <BANLkTine1Q7thbLVUb34ZsRZt4q184dZzg@mail.gmail.com>

On Tue, Jun 28, 2011 at 06:43 +0530, Balbir Singh wrote:
> On Fri, Jun 24, 2011 at 5:38 PM, Vasiliy Kulikov <segoon@openwall.com> wrote:
> > /proc/PID/io may be used for gathering private information.  E.g. for
> > openssh and vsftpd daemons wchars/rchars may be used to learn the
> > precise password length.  Restrict it to processes being able to ptrace
> > the target process.
> >
> 
> Hmm.. How do I reproduce this,

Just register taskstats listener and wait for "vsftpd" process.
read_characters = strlen("USER username\r\n") + strlen("PASSWD
pass\r\n") + 1.

> won't they be enough randomness around
> rchar/wchar by the time the attacker reads it?

No, if you set "UsePrivilegeSeparation yes" in /etc/sshd/sshd_config or
similar setting in vsftpd config (set by default), one process will
have very small io activity, which is 100% related to the io in
question.

http://www.openwall.com/lists/oss-security/2011/06/24/6

So, the total io = io with the network + io with privileged parent.


Thanks,

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments

      parent reply	other threads:[~2011-06-28  7:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-24 12:08 [PATCH 1/2] proc: restrict access to /proc/PID/io Vasiliy Kulikov
2011-06-27  2:58 ` KOSAKI Motohiro
2011-06-27  7:03   ` Vasiliy Kulikov
2011-06-27  7:33     ` KOSAKI Motohiro
2011-06-27  8:52       ` Vasiliy Kulikov
2011-06-27 10:07         ` KOSAKI Motohiro
2011-06-27 10:59           ` Vasiliy Kulikov
2011-06-27 22:37         ` Solar Designer
2011-06-28  1:24         ` Balbir Singh
2011-06-28  7:50           ` Vasiliy Kulikov
2011-06-29  1:16             ` Balbir Singh
2011-06-29 11:20               ` Vasiliy Kulikov
2011-06-28  1:13 ` Balbir Singh
2011-06-28  1:15   ` Balbir Singh
2011-06-28  7:50   ` Vasiliy Kulikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110628075027.GA4051@albatros \
    --to=segoon@openwall.com \
    --cc=akpm@linux-foundation.org \
    --cc=bsingharora@gmail.com \
    --cc=eparis@redhat.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=security@kernel.org \
    --cc=solar@openwall.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wilsons@start.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox