From: Greg KH <greg@kroah.com>
To: John Johansen <john.johansen@canonical.com>
Cc: linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, jmorris@namei.org
Subject: Re: [PATCH 2/2] AppArmor: Fix masking of capabilities in complain mode
Date: Tue, 28 Jun 2011 11:12:15 -0700 [thread overview]
Message-ID: <20110628181215.GA15843@kroah.com> (raw)
In-Reply-To: <1309276565-20776-3-git-send-email-john.johansen@canonical.com>
On Tue, Jun 28, 2011 at 04:56:05PM +0100, John Johansen wrote:
> AppArmor is masking the capabilities returned by capget against the
> capabilities mask in the profile. This is wrong, in complain mode the
> profile has effectively all capabilities, as the profile restrictions are
> not being enforced, merely tested against to determine is an access is
> known by the profile.
>
> This can result in the wrong behavior of security conscience applications
> like sshd which examine their capability set, and change their behavior
> accordingly. In this case because of the masked capability set being
> returned sshd fails due to DAC checks, even when the profile is complain
> mode.
>
> Kernels affected: 2.6.36 - 3.0
>
> Signed-off-by: John Johansen <john.johansen@canonical.com>
As this should probably go to the stable tree, next time care to add a
simple:
Cc: stable <stable@kernel.org>
to the signed-off-by: area of the patch so it gets automagically
included in the stable and longterm kernels as needed when it hits
Linus's tree?
thanks,
greg k-h
next prev parent reply other threads:[~2011-06-28 18:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 15:56 [Patch 0/2] Fixes for masking of complain mode, and rcu protected ref John Johansen
2011-06-28 15:56 ` [PATCH 1/2] AppArmor: Fix reference to rcu protected pointer outside of rcu_read_lock John Johansen
2011-06-28 15:56 ` [PATCH 2/2] AppArmor: Fix masking of capabilities in complain mode John Johansen
2011-06-28 18:12 ` Greg KH [this message]
2011-06-28 23:19 ` James Morris
-- strict thread matches above, loose matches on Subject: below --
2011-06-29 1:44 [Patch v2 0/2] Fix for masking of complain mode, and rcu protected ref John Johansen
2011-06-29 1:44 ` [PATCH 2/2] AppArmor: Fix masking of capabilities in complain mode John Johansen
2011-06-29 4:24 ` Greg KH
2011-06-29 7:55 ` John Johansen
2011-06-29 15:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110628181215.GA15843@kroah.com \
--to=greg@kroah.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox