Re: [git pull] PCI fixes

Kenji Kaneshige
2011-12-07T08:19:00Z

+ /* Configuration request Retry Status */
+ if (l == 0xffff0001)
+ goto wait;

I think this works only when CRS Software Visibility is enabled,
isn't it? Currently there is no code to enable CRS Software
Visibility. And there can be root ports that doesn't support CRS
Software Visibility. We need consideration about this.

+ mdelay(100);
+ delay -= 100;
+ if (delay > 0)
+ goto again;

We must use msleep() instead of mdelay().

Regards,
Kenji Kaneshige

(2011/12/07 7:36), Yinghai Lu wrote:
> On Tue, Dec 6, 2011 at 8:14 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>> Please try to make something like that work. Instead of always waiting
>> for one second, wait for up to one second only for failure cases. Any
>> possibility of that?
>
> i had another version that was not send out. that worked on my test setups too.
> it will try to read pci conf several times in 1s.
>
> please check refreshed version against your tree.
>
> Thanks
>
> Yinghai