From: Andrew Morton <akpm@linux-foundation.org>
To: Donggeun Kim <dg77.kim@samsung.com>
Cc: linux-kernel@vger.kernel.org, gregkh@suse.de,
rdunlap@xenotime.net, mk7.kang@samsung.com,
kyungmin.park@samsung.com
Subject: Re: [PATCH v5] misc: adds support the FSA9480 USB Switch
Date: Wed, 29 Jun 2011 12:55:34 -0700 [thread overview]
Message-ID: <20110629125534.4895f1d8.akpm@linux-foundation.org> (raw)
In-Reply-To: <1309342463-26481-1-git-send-email-dg77.kim@samsung.com>
On Wed, 29 Jun 2011 19:14:23 +0900
Donggeun Kim <dg77.kim@samsung.com> wrote:
> The FSA9480 is a USB port accessory detector and switch.
> This patch adds support the FSA9480 USB Switch.
>
> ...
>
> +static struct fsa9480_usbsw *chip;
So there can only ever be one device per system. Is this a good
assumption?
Does this fix look OK?
--- a/drivers/misc/fsa9480.c~drivers-misc-add-support-the-fsa9480-usb-switch-fix
+++ a/drivers/misc/fsa9480.c
@@ -145,7 +145,7 @@ static int fsa9480_read_irq(struct i2c_c
return ret;
}
-void fsa9480_set_switch(const char *buf)
+static void fsa9480_set_switch(const char *buf)
{
struct fsa9480_usbsw *usbsw = chip;
struct i2c_client *client = usbsw->client;
@@ -179,7 +179,7 @@ void fsa9480_set_switch(const char *buf)
fsa9480_write_reg(client, FSA9480_REG_CTRL, value);
}
-ssize_t fsa9480_get_switch(char *buf)
+static ssize_t fsa9480_get_switch(char *buf)
{
struct fsa9480_usbsw *usbsw = chip;
struct i2c_client *client = usbsw->client;
_
next prev parent reply other threads:[~2011-06-29 19:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 6:56 [PATCH v3] misc: adds support the FSA9480 USB Switch Minkyu Kang
2011-03-08 13:59 ` Greg KH
2011-03-08 23:59 ` Minkyu Kang
2011-03-09 0:09 ` Greg KH
2011-03-09 0:41 ` Minkyu Kang
2011-03-09 8:34 ` [PATCH v4] " Minkyu Kang
2011-06-29 10:14 ` [PATCH v5] " Donggeun Kim
2011-06-29 11:34 ` anish singh
2011-06-29 19:55 ` Andrew Morton [this message]
2011-03-08 21:02 ` [PATCH v3] " Dave Jones
2011-03-09 0:01 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110629125534.4895f1d8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dg77.kim@samsung.com \
--cc=gregkh@suse.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mk7.kang@samsung.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox