public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"viresh kumar" <viresh.kumar@st.com>,
	"Shawn Guo" <shawn.guo@linaro.org>,
	"Ryan Mallon" <ryan@bluewatersys.com>,
	"Kurt Van Dijck" <kurt.van.dijck@eia.be>,
	"Matthias Kaehlcke" <matthias@kaehlcke.net>,
	"Lothar Waßmann" <LW@karo-electronics.de>
Subject: Re: [PATCH 1/2] PWM: add pwm framework support
Date: Wed, 29 Jun 2011 13:41:48 +0200	[thread overview]
Message-ID: <201106291341.48317.arnd@arndb.de> (raw)
In-Reply-To: <1309338215-10702-2-git-send-email-s.hauer@pengutronix.de>

On Wednesday 29 June 2011, Sascha Hauer wrote:
> This patch adds framework support for PWM (pulse width modulation) devices.

Hi Sascha,

The code looks all good now, but it seems you missed the three trivial remarks
I had about the documentation. It would be good to just fix them, but not
essential.

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

  parent reply	other threads:[~2011-06-29 11:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29  9:03 [PATCH v2] implement a generic PWM framework Sascha Hauer
2011-06-29  9:03 ` [PATCH 1/2] PWM: add pwm framework support Sascha Hauer
2011-06-29 11:38   ` Kurt Van Dijck
2011-06-29 11:41   ` Arnd Bergmann [this message]
2011-06-29 19:47   ` Matthias Kaehlcke
2011-06-29  9:03 ` [PATCH 2/2] pwm: Add a i.MX23/28 pwm driver Sascha Hauer
2011-06-29 11:37   ` Arnd Bergmann
  -- strict thread matches above, loose matches on Subject: below --
2011-06-28 10:02 [RFC] implement a generic PWM framework - once again Sascha Hauer
2011-06-28 10:02 ` [PATCH 1/2] PWM: add pwm framework support Sascha Hauer
2011-06-28 11:14   ` Kurt Van Dijck
2011-06-28 12:27   ` Arnd Bergmann
2011-06-28 16:18     ` Sascha Hauer
2011-06-28 17:03       ` Arnd Bergmann
2011-06-29  8:50         ` Sascha Hauer
2011-06-29 11:00           ` Arnd Bergmann
2011-06-28 19:40   ` Matthias Kaehlcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106291341.48317.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=LW@karo-electronics.de \
    --cc=kurt.van.dijck@eia.be \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias@kaehlcke.net \
    --cc=ryan@bluewatersys.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    --cc=viresh.kumar@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox