From: Arnd Bergmann <arnd@arndb.de>
To: Johannes Stezenbach <js@sig21.net>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: missing compat-ioctl for CDROM_DRIVE_STATUS + FDGETPRM
Date: Wed, 29 Jun 2011 14:30:42 +0200 [thread overview]
Message-ID: <201106291430.43102.arnd@arndb.de> (raw)
In-Reply-To: <20110629113834.GA4227@sig21.net>
On Wednesday 29 June 2011, Johannes Stezenbach wrote:
> Sorry for very slow reply. I think qemu's use of these ioctls
> to probe if the device is a cdrom or floppy is valid, so instead
> of adding a stat() call to check for block device in qemu, I think
> it is better to silence the warning in the kernel.
Well, correct or not, it will keep causing annoying messages on
old kernels, so why not do both?
> Do I get it right that just adding two IGNORE_IOCTL() to
> the ioctl_pointer array in linux/fs/compat_ioctl.c is sufficient,
> like in commit 3f001711?
Yes.
> I.e. these ioctls are handled for block devices earlier
> in compat_sys_ioctl()?
Right. We always first ask the driver, and then search the lookup table
when the driver does not know how to handle it in compat mode.
Arnd
next prev parent reply other threads:[~2011-06-29 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 9:04 missing compat-ioctl for CDROM_DRIVE_STATUS + FDGETPRM Johannes Stezenbach
2011-06-17 13:02 ` Arnd Bergmann
2011-06-29 11:38 ` Johannes Stezenbach
2011-06-29 12:30 ` Arnd Bergmann [this message]
2011-06-29 12:51 ` Johannes Stezenbach
2011-06-29 15:09 ` Johannes Stezenbach
2011-06-29 15:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106291430.43102.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=js@sig21.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox