From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@infradead.org>,
Anton Salikhmetov <alexo@tuxera.com>,
linux-kernel@vger.kernel.org
Subject: Re: hfsplus mount regression in 2.6.38
Date: Thu, 30 Jun 2011 07:35:20 -0400 [thread overview]
Message-ID: <20110630113520.GA6744@infradead.org> (raw)
In-Reply-To: <20110602215821.GA13099@thinkpad-t410>
On Thu, Jun 02, 2011 at 04:58:21PM -0500, Seth Forshee wrote:
> I took a crack at converting the users of direct bio to use
> bdev_logical_block_size instead of HFSPLUS_SECTOR_SIZE. sb->s_blocksize
> doesn't turn out to work because it may change after reading the
> volume header. The patch is below; feedback is appreciated.
>
> So far I've only done light testing, and no testing with large-sector
> devices since I don't have any to test with. I'm still concerned about
> duplicating data also in the page cache with this approach. Any thoughts
> on whether or not this is something to be worried about?
Did you manage to test it on a large sector device?
I'm be rather surprised if we actually need the read modify write
cycles. I've not seen any filesystem that doesn't align it's metadata
to the sector size yet.
next prev parent reply other threads:[~2011-06-30 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 14:25 hfsplus mount regression in 2.6.38 Seth Forshee
2011-05-27 9:25 ` Christoph Hellwig
2011-05-27 13:23 ` Seth Forshee
2011-05-27 18:24 ` Seth Forshee
2011-06-02 21:58 ` Seth Forshee
2011-06-30 11:35 ` Christoph Hellwig [this message]
2011-06-30 13:10 ` Seth Forshee
2011-06-30 13:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630113520.GA6744@infradead.org \
--to=hch@infradead.org \
--cc=alexo@tuxera.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox