Re: [PATCH] perf report/annotate: Add option to specify a CPU range

Ingo Molnar
2011-07-01T11:16:56Z

* David Ahern <dsahern@gmail.com> wrote:

> > @@ -262,6 +271,41 @@ static int __cmd_report(void)
> > if (session == NULL)
> > return -ENOMEM;
> >
> > + if (cpu_list) {
> > + int i;
> > + struct cpu_map *map;
> > +
> > + for (i = 0; i < PERF_TYPE_MAX; ++i) {
> > + struct perf_evsel *evsel;
> > +
> > + evsel = perf_session__find_first_evtype(session, i);
> > + if (!evsel)
> > + continue;
> > +
> > + if (!(evsel->attr.sample_type & PERF_SAMPLE_CPU)) {
> > + pr_err("File does not contain CPU events. "
> > + "Remove -c option to proceed.\n");
> > + ret = -1;
> > + goto out_delete;
> > + }
> > + }
> > +
> > + map = cpu_map__new(cpu_list);
> > +
> > + for (i = 0; i < map->nr; i++) {
> > + int cpu = map->map[i];
> > +
> > + if (cpu >= MAX_NR_CPUS) {
> > + pr_err("Requested CPU %d too large. "
> > + "Consider raising MAX_NR_CPUS\n", cpu);
> > + ret = -1;
> > + goto out_delete;
> > + }
> > +
> > + set_bit(cpu, cpu_bitmap);
> > + }
> > + }
> > +
>
> It would be better to make this a function that all 3 commands
> reference -- something like perf_session__cpu_bitmap(session,
> cpu_list, cpu_bitmap) in util/session.c

Agreed. I can see how it ended up looking like this (fixing only perf
report, then adding it to top, then to script), but at this stage it
really calls for one helper that all three commands can utilize.

Very nice enhancement otherwise - might i suggest a 'perf top' hotkey
as well to limit the output to certain CPUs only? :-)

Thanks,

Ingo