Re: [PATCH 3/9] writeback: bdi write bandwidth estimation

Wu Fengguang
2011-07-08T14:15:54Z

Andrea,

> Another small time nitpick.
>
> > +
> > +static void bdi_update_bandwidth(struct backing_dev_info *bdi,
> > + unsigned long start_time)
> > +{
> > + if (jiffies - bdi->bw_time_stamp <= MAX_PAUSE + MAX_PAUSE / 10)
>
> if (time_is_after_eq_jiffies(bdi->bw_time_stamp + MAX_PAUSE +
> MAX_PAUSE / 10)

Done, and simplified to

if (time_is_after_eq_jiffies(bdi->bw_time_stamp + BANDWIDTH_INTERVAL))
return;

Thanks,
Fengguang