From: Arnd Bergmann <arnd@arndb.de>
To: Johannes Stezenbach <js@sig21.net>
Cc: Kevin Wolf <kwolf@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH resend] compat_ioctl: fix warning caused by qemu
Date: Fri, 1 Jul 2011 16:46:28 +0200 [thread overview]
Message-ID: <201107011646.28918.arnd@arndb.de> (raw)
In-Reply-To: <20110701093336.GA9582@sig21.net>
On Friday 01 July 2011, Johannes Stezenbach wrote:
>
> On Linux x86_64 host with 32bit userspace, running
> qemu or even just "qemu-img create -f qcow2 some.img 1G"
> causes a kernel warning:
>
> ioctl32(qemu-img:5296): Unknown cmd fd(3) cmd(00005326){t:'S';sz:0} arg(7fffffff) on some.img
> ioctl32(qemu-img:5296): Unknown cmd fd(3) cmd(801c0204){t:02;sz:28} arg(fff77350) on some.img
>
> ioctl 00005326 is CDROM_DRIVE_STATUS,
> ioctl 801c0204 is FDGETPRM.
>
> The warning appears because the Linux compat-ioctl handler for these
> ioctls only applies to block devices, while qemu also uses the ioctls on
> plain files.
>
> Signed-off-by: Johannes Stezenbach <js@sig21.net>
Acked-by: Arnd Bergmann <arnd@arndb.de>
> ---
> (resend with Cc: suggested by get_maintainer.pl)
>
> discussed in http://lkml.kernel.org/r/20110617090424.GA19345@sig21.net
>
> Arnd, is this what you had in mind, or did you mean to move
> all floppy compat definitions? I decided to go with the
> minimal change. Tested on both 2.6.39.2 and 3.0-rc5-63-g0d72c6f.
Yes, that should be fine, unless Jens would like to see a different
solution for the struct definitions, e.g. moving all of the floppy
compat ioctl numbers to fd.h. I'm fine with it either way.
Arnd
next prev parent reply other threads:[~2011-07-01 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 9:33 [PATCH resend] compat_ioctl: fix warning caused by qemu Johannes Stezenbach
2011-07-01 14:46 ` Arnd Bergmann [this message]
2011-07-01 20:34 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107011646.28918.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=js@sig21.net \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox