From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753866Ab1GBHgd (ORCPT ); Sat, 2 Jul 2011 03:36:33 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:33293 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753628Ab1GBHgc (ORCPT ); Sat, 2 Jul 2011 03:36:32 -0400 Date: Sat, 2 Jul 2011 11:36:25 +0400 From: Vasiliy Kulikov To: Balbir Singh , Linus Torvalds Cc: linux-kernel@vger.kernel.org, Andrew Morton , Al Viro , David Rientjes , Stephen Wilson , KOSAKI Motohiro , security@kernel.org, Eric Paris , kernel-hardening@lists.openwall.com Subject: Re: [PATCH 2/2] taskstats: restrict access to user Message-ID: <20110702073625.GA3318@albatros> References: <1308917362-4795-1-git-send-email-segoon@openwall.com> <20110629201718.GA11071@albatros> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20110629201718.GA11071@albatros> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 30, 2011 at 00:17 +0400, Vasiliy Kulikov wrote: > On Wed, Jun 29, 2011 at 06:57 +0530, Balbir Singh wrote: > > On Fri, Jun 24, 2011 at 5:39 PM, Vasiliy Kulikov wrote: > > > +               task = find_task_by_vpid(s->pid); > > > +               if (!task || __task_cred(task)->euid != cred->euid) { > > If consider this patch for inclusion, it also needs some check for > the listener root ability. __task_cred(task)->euid == 0 or smth like > that. But ptrace_task_may_access_current() is better. So... What to do with this patch? Should I resend it with euid==0 and rcu optimication, wait for the new ptrace interface or what? Thanks, -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments