From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Turner <pjt@google.com>,
linux-kernel@vger.kernel.org, Mike Galbraith <efault@gmx.de>
Subject: Re: [patch 1/1] sched: update_curr versus correct cfs_rq in check_preempt_wakeup
Date: Sat, 2 Jul 2011 12:27:21 +0200 [thread overview]
Message-ID: <20110702102721.GE17482@elte.hu> (raw)
In-Reply-To: <1309600625.10073.8.camel@twins>
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Sat, 2011-07-02 at 11:08 +0200, Ingo Molnar wrote:
> > * Paul Turner <pjt@google.com> wrote:
> >
> > > We update_curr() versus the current entity as the preemption
> > > decision is based on the relative vruntime. However, update_curr()
> > > is not hierarchical and in the group scheduling case
> > > find_matching_se() will have us making the comparison on a cfs_rq
> > > different to the one just updated.
> >
> > Would be nice to include more contextual information in the
> > changelog: how did you find it, what effect (if any) did you see
> > from this patch, what effect do you expect others to see (if
> > any).
>
> Agreed that the Changelog can be improved. From talking to pjt on
> IRC though, I think he spotted this by reading through the code.
'code review' is a perfect answer to the 'how did you find it'
question: when people read the changelog they will know that no
practical effect has been observed (yet).
Thanks,
Ingo
next prev parent reply other threads:[~2011-07-02 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110702005222.262883892@google.com>
2011-07-02 0:52 ` [patch 1/1] sched: update_curr versus correct cfs_rq in check_preempt_wakeup Paul Turner
2011-07-02 9:08 ` Ingo Molnar
2011-07-02 9:57 ` Peter Zijlstra
2011-07-02 10:27 ` Ingo Molnar [this message]
2011-07-06 2:07 ` Paul Turner
2011-07-21 18:27 ` [tip:sched/core] sched: update correct entity's runtime in check_preempt_wakeup() tip-bot for Paul Turner
2011-07-06 1:54 ` [patch 1/1] sched: update_curr versus correct cfs_rq in check_preempt_wakeup Paul Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110702102721.GE17482@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pjt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox