Re: Build regressions/improvements in v3.0-rc5 (xfs on cris)

Américo Wang
2011-06-30T08:34:12Z

On Thu, Jun 30, 2011 at 5:24 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Jun 29, 2011 at 02:21:06PM -0700, Randy Dunlap wrote:
>> Looks like arch/cris does not support atomic64_t.  (?)
>>
>> Should we prevent xfs from being built on arch/cris?
>
> Or nuke cris until it's able to at least include an asm-generic header?
>

Not that simple. Take a look at lib/atomic64_test.c, it said:

#if defined(CONFIG_X86) || defined(CONFIG_MIPS) || defined(CONFIG_PPC) || \
defined(CONFIG_S390) || defined(_ASM_GENERIC_ATOMIC64_H) ||
defined(CONFIG_ARM)
...
#else
#warning Please implement atomic64_dec_if_positive for your
architecture, and add it to the IF above
#endif

So cris at least needs to implement atomic64_dec_if_positive()...