Re: [PATCH 0/5 v2] PCI: fix cardbus and sriov regressions

Ben Hutchings
2011-07-01T23:07:57Z

On Thu, 2011-06-30 at 16:47 -0700, Ram Pai wrote:
> The following patch-set fixes regressions caused by:
>
> the commit "PCI: update bridge resources to get more big ranges when allocating space (again)"
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=da7822e5ad71ec9b745b412639f1e5e0ba795a20
>
> patch 1/5: fix calculation of additional resource size for hotplug bridges
> patch 2/5: ability to resize assigned pci-resource
> patch 3/5: make SRIOV BARs resources optional
> patch 4/5: make cardbus bridge resources optional
> patch 5/5: code and terminology cleanup
>
> The regression was caused on some platforms with limited i/o and memory
> resources, the optional resources were allocated ahead of required resources,
> thus starving the latter. The patchset ensures that all the required resources
> are satisfied before any optional resources are satisfied.

This certainly fixes the problem I originally reported: all the basic
BARs for devices with SR-IOV enabled are mapped.

When testing this, I noticed that a BAR which we fail to allocate space
for may be left configured with an address range that overlaps that of
other BARs. However, that does not appear to be a regression.

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.