Re: [PATCH 0/2] netpoll: Trivial updates

Joe Perches
2011-07-01T03:35:51Z

On Fri, 2011-07-01 at 11:26 +0800, Cong Wang wrote:
> 于 2011年07月01日 09:08, Joe Perches 写道:
> > cc: WANG Cong<amwang@redhat.com>
> > Joe Perches (2):
> > netpoll: Remove unused EXPORT_SYMBOLs of netpoll_poll and netpoll_poll_dev
> > netpoll: Remove trivial wrapper function netpoll_poll
> > include/linux/netpoll.h | 2 --
> > net/core/netpoll.c | 13 +++----------
> > 2 files changed, 3 insertions(+), 12 deletions(-)
> I am fine with patch 1/2, but not 2/2, since it is trivial,
> why touch it? With netpoll_poll(), we don't need to explore the
> details of struct netpoll, I think it is nice to have it.

Shrug. Neither is used. Keep things minimal.

> BTW, you can kill the export of netpoll_send_skb_on_dev() too.

Not too sure about that.

It's used in netpoll.h by netpoll_send_skb.
It could be called from anywhere.
It's currently called/used by bonding.h.

cheers, Joe